Project

Profile

Help

Story #2525

closed

Failover events should be explicitly logged as such when they occur

Added by dalley over 7 years ago. Updated about 5 years ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Low
Assignee:
Category:
-
Sprint/Milestone:
-
Start date:
Due date:
% Done:

100%

Estimated time:
Platform Release:
2.12.0
Groomed:
Yes
Sprint Candidate:
Yes
Tags:
Easy Fix, Pulp 2
Sprint:
Sprint 14
Quarter:

Description

Problem

pulp_resource_manager and pulp_celerybeat both use hot-spare processes for high availability. The current behavior logs when a worker go missing, when a new ones comes online, and when the lock is acquired.

Solution

Whenever a pulp_resource_manager or pulp_celerybeat instance is a hot spare (could not require the lock) and then becomes the primary (acquires the lock), logs should notify the user that failover has occurred. Specifically at WARNING level, it should log the following:

Failover occured: xxxxxx is now the primary

Additionally, the "lock acquired" log statement should be switched to DEBUG since the WARNING statement will be shown to the user at that same moment.

Actions #1

Updated by bmbouter over 7 years ago

Do you think this should be at the WARNING level?

Actions #2

Updated by dalley over 7 years ago

  • Assignee set to dalley
Actions #3

Updated by dalley over 7 years ago

  • Status changed from NEW to ASSIGNED
Actions #4

Updated by dalley over 7 years ago

  • Status changed from ASSIGNED to NEW
  • Assignee deleted (dalley)
Actions #5

Updated by dalley over 7 years ago

Yes, I think that would be appropriate.

Actions #6

Updated by bmbouter over 7 years ago

  • Description updated (diff)
  • Sprint Candidate changed from No to Yes
Actions #7

Updated by bmbouter over 7 years ago

Actions #8

Updated by bmbouter over 7 years ago

I've rewritten this some. Now it suggests that these WARNING level logs will replace the "lock acquired" logs. I think that is good because that is effectively what that log statement means.

Is ^ a good idea?
Would it be better to just add the WARNING level statement, and convert the "lock acquired" ones to DEBUG?

Actions #9

Updated by dalley over 7 years ago

I think the latter suggestion would be good - keep the lock acquired logs but make them DEBUG level

Actions #10

Updated by dalley over 7 years ago

  • Description updated (diff)
Actions #11

Updated by bmbouter over 7 years ago

  • Description updated (diff)
Actions #12

Updated by dalley over 7 years ago

Actions #13

Updated by dalley over 7 years ago

Actions #14

Updated by dalley over 7 years ago

Actions #15

Updated by dalley over 7 years ago

Actions #16

Updated by dalley over 7 years ago

  • Status changed from NEW to ASSIGNED
  • Assignee set to dalley
  • Groomed changed from No to Yes
Actions #17

Updated by dalley over 7 years ago

  • Status changed from ASSIGNED to POST
Actions #18

Updated by dalley over 7 years ago

  • Sprint/Milestone set to 32

Added by dalley over 7 years ago

Revision 34c45b2d | View on GitHub

Explictly log failovers

Failover events are now logged as such at the WARNING level

closes #2525

Added by dalley over 7 years ago

Revision 34c45b2d | View on GitHub

Explictly log failovers

Failover events are now logged as such at the WARNING level

closes #2525

Actions #19

Updated by dalley over 7 years ago

  • Status changed from POST to MODIFIED
  • % Done changed from 0 to 100
Actions #20

Updated by semyers over 7 years ago

  • Platform Release set to 2.12.0
Actions #21

Updated by semyers over 7 years ago

  • Status changed from MODIFIED to 5
Actions #22

Updated by semyers about 7 years ago

  • Status changed from 5 to CLOSED - CURRENTRELEASE
Actions #25

Updated by bmbouter about 6 years ago

  • Sprint set to Sprint 16
Actions #26

Updated by bmbouter about 6 years ago

  • Sprint changed from Sprint 16 to Sprint 14
Actions #27

Updated by bmbouter about 6 years ago

  • Sprint/Milestone deleted (32)
Actions #28

Updated by bmbouter about 5 years ago

  • Tags Pulp 2 added

Also available in: Atom PDF