Issue #2512: Puppet Importer swallows exception when one is raised during upload - Puppet Support - Pulp

Actions

Send by e-mail Copy link

Issue #2512

closed

Puppet Importer swallows exception when one is raised during upload

Added by dkliban@redhat.com almost 8 years ago. Updated over 5 years ago.

Status:

CLOSED - CURRENTRELEASE

Priority:

Normal

Assignee:

Start date:

Due date:

Estimated time:

Severity:

2. Medium

Version:

Platform Release:

2.13.0

OS:

Triaged:

Yes

Groomed:

No

Sprint Candidate:

No

Tags:

Pulp 2

Sprint:

Sprint 18

Quarter:

Description

The upload_unit method in the Puppet Importer[0] catches an exception experienced during upload and then returns a generic progress report. As a result the actual exception is never propagated to the user.

This problem can be reproduced with the following steps:

pulp-admin puppet repo create --repo-id blah
touch blah-blah-1.2.1.tar.gz
pulp-admin puppet repo uploads upload -f blah-blah-1.2.1.tar.gz --repo-id blah

[0] https://github.com/pulp/pulp_puppet/blob/2.11-dev/pulp_puppet_plugins/pulp_puppet/plugins/importers/importer.py#L83

Related issues

Actions

#1

Updated by dkliban@redhat.com almost 8 years ago

Subject changed from importer catches exception when one is raised during upload to Puppet Importer swallows exception when one is raised during upload

Actions

#2

Updated by daviddavis almost 8 years ago

Related to Issue #2500: ValueError exception is raised when uploading module with invalid name added

Actions

#4

Updated by bizhang almost 8 years ago

Triaged changed from No to Yes

Actions

#5

Updated by mhrivnak almost 8 years ago

Sprint/Milestone set to 32

Actions

#6

Updated by dalley almost 8 years ago

Related to Issue #2543: RPM Importer swallows exception when one is raised during upload added

Actions

#7

Updated by mhrivnak almost 8 years ago

Sprint/Milestone changed from 32 to 33

Actions

#8

Updated by daviddavis almost 8 years ago

Status changed from NEW to ASSIGNED
Assignee set to daviddavis

Actions

#9

Updated by daviddavis almost 8 years ago

Status changed from ASSIGNED to POST

https://github.com/pulp/pulp_puppet/pull/253

Actions

#10

Updated by mhrivnak almost 8 years ago

Sprint/Milestone changed from 33 to 34

Actions

#12

Updated by daviddavis almost 8 years ago

Opened an issue against Katello:

http://projects.theforeman.org/issues/18721

Actions

#13

Updated by mhrivnak almost 8 years ago

Sprint/Milestone changed from 34 to 36

Actions

#14

Updated by mhrivnak over 7 years ago

Sprint/Milestone changed from 36 to 37

Added by daviddavis over 7 years ago

Revision 5608e855 | View on GitHub

Allow puppet upload errors to propagate

Changing upload errors to PulpCodedExceptions so they can propagate the error message to the user.

closes #2512 https://pulp.plan.io/issues/2512

Actions

#15

Updated by daviddavis over 7 years ago

Status changed from POST to MODIFIED

Applied in changeset 5608e855cbe5953d3dab00550a07d5883d8c7227.

Actions

#16

Updated by pcreech over 7 years ago

Platform Release set to 2.13.0

Actions

#17

Updated by pcreech over 7 years ago

Status changed from MODIFIED to 5

Actions

#18

Updated by pcreech over 7 years ago

Status changed from 5 to CLOSED - CURRENTRELEASE

Actions

#19

Updated by bmbouter almost 7 years ago

Sprint set to Sprint 18

Actions

#20

Updated by bmbouter almost 7 years ago

Sprint/Milestone deleted (37)

Actions

#21

Updated by bmbouter over 5 years ago

Tags Pulp 2 added

Actions

Send by e-mail Copy link

Also available in: Atom PDF