Project

Profile

Help

Issue #2512

Puppet Importer swallows exception when one is raised during upload

Added by dkliban@redhat.com over 2 years ago. Updated 5 months ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Assignee:
Category:
-
Sprint/Milestone:
-
Start date:
Due date:
Severity:
2. Medium
Version:
Platform Release:
2.13.0
Blocks Release:
OS:
Backwards Incompatible:
No
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
Pulp 2
QA Contact:
Complexity:
Smash Test:
Verified:
No
Verification Required:
No
Sprint:
Sprint 18

Description

The upload_unit method in the Puppet Importer0 catches an exception experienced during upload and then returns a generic progress report. As a result the actual exception is never propagated to the user.

This problem can be reproduced with the following steps:

pulp-admin puppet repo create --repo-id blah
touch blah-blah-1.2.1.tar.gz
pulp-admin puppet repo uploads upload -f blah-blah-1.2.1.tar.gz --repo-id blah

[0] https://github.com/pulp/pulp_puppet/blob/2.11-dev/pulp_puppet_plugins/pulp_puppet/plugins/importers/importer.py#L83


Related issues

Related to Puppet Support - Issue #2500: ValueError exception is raised when uploading module with invalid name CLOSED - CURRENTRELEASE Actions
Related to RPM Support - Issue #2543: RPM Importer swallows exception when one is raised during upload CLOSED - CURRENTRELEASE Actions

Associated revisions

Revision 5608e855 View on GitHub
Added by daviddavis over 2 years ago

Allow puppet upload errors to propagate

Changing upload errors to PulpCodedExceptions so they can propagate the
error message to the user.

closes #2512
https://pulp.plan.io/issues/2512

History

#1 Updated by dkliban@redhat.com over 2 years ago

  • Subject changed from importer catches exception when one is raised during upload to Puppet Importer swallows exception when one is raised during upload

#2 Updated by daviddavis over 2 years ago

  • Related to Issue #2500: ValueError exception is raised when uploading module with invalid name added

#4 Updated by bizhang over 2 years ago

  • Triaged changed from No to Yes

#5 Updated by mhrivnak over 2 years ago

  • Sprint/Milestone set to 32

#6 Updated by dalley over 2 years ago

  • Related to Issue #2543: RPM Importer swallows exception when one is raised during upload added

#7 Updated by mhrivnak over 2 years ago

  • Sprint/Milestone changed from 32 to 33

#8 Updated by daviddavis over 2 years ago

  • Status changed from NEW to ASSIGNED
  • Assignee set to daviddavis

#9 Updated by daviddavis over 2 years ago

  • Status changed from ASSIGNED to POST

#10 Updated by mhrivnak over 2 years ago

  • Sprint/Milestone changed from 33 to 34

#12 Updated by daviddavis over 2 years ago

Opened an issue against Katello:

http://projects.theforeman.org/issues/18721

#13 Updated by mhrivnak over 2 years ago

  • Sprint/Milestone changed from 34 to 36

#14 Updated by mhrivnak over 2 years ago

  • Sprint/Milestone changed from 36 to 37

#15 Updated by daviddavis over 2 years ago

  • Status changed from POST to MODIFIED

#16 Updated by pcreech over 2 years ago

  • Platform Release set to 2.13.0

#17 Updated by pcreech over 2 years ago

  • Status changed from MODIFIED to ON_QA

#18 Updated by pcreech over 2 years ago

  • Status changed from ON_QA to CLOSED - CURRENTRELEASE

#19 Updated by bmbouter over 1 year ago

  • Sprint set to Sprint 18

#20 Updated by bmbouter over 1 year ago

  • Sprint/Milestone deleted (37)

#21 Updated by bmbouter 5 months ago

  • Tags Pulp 2 added

Please register to edit this issue

Also available in: Atom PDF