Issue #2349
closed
Repoview left in place even when not requested
Description
Pulp has a "repoview" feature documented here: https://pulp.plan.io/issues/189
A test for this feature is as follows:
1. Create an RPM repository, and add some content to it.
2. Publish the repository. Get /pulp/repos/{rel_url}/, and verify that no redirects occur.
3. Publish the repository with the repoview and generate_sqlite options set to true. Get /pulp/repos/{rel_url}/, and verify that a redirect to /pulp/repos/{rel_url}/repoview/index.html occurs.
4. Repeat step 2.
Unfortunately, the final step will fail. Pulp will redirect a client's request to /pulp/repos/{rel_url}/repoview/index.html. You can even modify the test as follows, and the redirect will still occur:
1. Create an RPM repository, and add some content to it.
2. Publish the repository. Get /pulp/repos/{rel_url}/, and verify that no redirects occur.
3. Publish the repository with the repoview and generate_sqlite options set to true. Get /pulp/repos/{rel_url}/, and verify that a redirect to /pulp/repos/{rel_url}/repoview/index.html occurs.
4. Add more content to the repository.
5. Repeat step 2.
This behaviour seems incorrect to me. In my opinion, Pulp should provide a repoview when requested, and it should not provide a repoview when not requested.
Updated by amacdona@redhat.com over 7 years ago
- Severity changed from 2. Medium to 1. Low
- Triaged changed from No to Yes
Updated by mhrivnak over 7 years ago
I assume in step 3, you are providing those config values with the call, so they only apply to that call and are not stored persistently.
It's likely that the incremental publish logic is copying the repoview files over from the previous publish just because they happen to be there. That also means the repoview data could be incorrect when you publish in step 4, because it would represent a previous state of the repo.
A great change would be to make sure the copying for incremental publish is careful to include only appropriate files.
That said, since this only affects humans browsing the repo, and you can work around it by doing a full publish, we triaged this to low severity.
Updated by bmbouter about 5 years ago
- Status changed from NEW to CLOSED - WONTFIX
Pulp 2 is approaching maintenance mode, and this Pulp 2 ticket is not being actively worked on. As such, it is being closed as WONTFIX. Pulp 2 is still accepting contributions though, so if you want to contribute a fix for this ticket, please reopen or comment on it. If you don't have permissions to reopen this ticket, or you want to discuss an issue, please reach out via the developer mailing list.
.