Project

Profile

Help

Story #229

closed

Add new task state: cancel_requested

Added by rbarlow almost 8 years ago. Updated almost 4 years ago.

Status:
CLOSED - WONTFIX
Priority:
Normal
Assignee:
-
Category:
-
Sprint/Milestone:
-
Start date:
Due date:
% Done:

0%

Estimated time:
Platform Release:
Groomed:
No
Sprint Candidate:
No
Tags:
Pulp 2
Sprint:
Quarter:

Description

++ This bug was initially created as a clone of Bugzilla Bug #1094523 ++

Description of problem:

I think it would be a worthwhile enhancement to distinguish between cancel_requested and canceled. The REST API could mark a task as cancel_requested, and once the worker successfully handles the request it can mark the task as canceled.

This would be handy for the CLI. The CLI currently exits immediately when polling tasks upon noticing that they are canceled. It could instead mark that the task has been requested to cancel, and wait to exit until it is actually exited. This would allow it to print the final progress report if there is one.

This would have aided in discovering the problem in #1082802[0], wherein it was found that cancellation was ignored.

[0] https://bugzilla.redhat.com/show_bug.cgi?id=1082802


Related issues

Related to Pulp - Story #1111: As an API user, I can purge completed task status recordsCLOSED - CURRENTRELEASEsbhawsin

Actions
Actions #1

Updated by rbarlow over 7 years ago

  • Blocks Story #1111: As an API user, I can purge completed task status records added
Actions #2

Updated by rbarlow over 7 years ago

  • Blocks deleted (Story #1111: As an API user, I can purge completed task status records)
Actions #3

Updated by rbarlow over 7 years ago

  • Related to Story #1111: As an API user, I can purge completed task status records added
Actions #4

Updated by rbarlow almost 7 years ago

  • Platform Release set to 3.0.0
  • Sprint Candidate changed from No to Yes

This would be great to fix with Pulp 3 so I'll mark it with that target release. We can remove that if we decide not to, but I think it would be easy to do this and would remove some ambiguity.

Actions #5

Updated by bmbouter almost 7 years ago

  • Subject changed from [RFE] Add new task state: cancel_requested to Add new task state: cancel_requested

When we switch to an exit-immediately behavior upon cancel there will be almost no delay in between a cancel being requested and the task from stopping. Formally it's still probably right to introduce a cancel_requested and then a final cancel state. Just an FYI on how that other change will affect the usefulness of this one.

Actions #6

Updated by mhrivnak over 6 years ago

  • Sprint Candidate changed from Yes to No
Actions #7

Updated by bmbouter almost 4 years ago

  • Status changed from NEW to CLOSED - WONTFIX
Actions #8

Updated by bmbouter almost 4 years ago

Pulp 2 is approaching maintenance mode, and this Pulp 2 ticket is not being actively worked on. As such, it is being closed as WONTFIX. Pulp 2 is still accepting contributions though, so if you want to contribute a fix for this ticket, please reopen or comment on it. If you don't have permissions to reopen this ticket, or you want to discuss an issue, please reach out via the developer mailing list.

Actions #9

Updated by bmbouter almost 4 years ago

  • Tags Pulp 2 added
Actions #10

Updated by daviddavis almost 4 years ago

  • Platform Release deleted (3.0.0)

Added by Fabricio Aguiar over 1 year ago

Revision 33e01088

Image pull policy defaults to IfNotPresent

closes #229

Also available in: Atom PDF