Project

Profile

Help

Issue #2177

download_repo task fails to mark some units as downloaded

Added by mhrivnak about 3 years ago. Updated 6 months ago.

Status:
CLOSED - WONTFIX
Priority:
Normal
Assignee:
-
Category:
-
Sprint/Milestone:
-
Start date:
Due date:
Severity:
2. Medium
Version:
2.8.7
Platform Release:
Blocks Release:
OS:
Backwards Incompatible:
No
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
Pulp 2
QA Contact:
Complexity:
Smash Test:
Verified:
No
Verification Required:
No
Sprint:

Description

If you run the download_repo task with the "verify_all_units" option, for any unit where all of the files are already present on disk and pass validation, the task will not set the unit's "downloaded" attribute to True.

1. create a repo with download policy of immediate
2. sync the repo
3. drop the database and re-run pulp-manage-db
4. re-create the repo with download policy of on_demand
5. sync the repo
6. run the download_repo task with "verify_all_units" set to True

You can then observe that the units are all present in the DB and on the filesystem, and they are associated with the repo, but their "downloaded" attributes in the DB are all False.

The solution is likely to separate this block into its own function:

https://github.com/pulp/pulp/blob/pulp-2.8.6-1/server/pulp/server/controllers/repository.py#L1485-L1491

and then also call it from here:

https://github.com/pulp/pulp/blob/pulp-2.8.6-1/server/pulp/server/controllers/repository.py#L1433



Related issues

Related to RPM Support - Story #236: Don't re-download rpms if they exist on disk CLOSED - CURRENTRELEASE Actions

History

#1 Updated by mhrivnak about 3 years ago

  • Related to Story #236: Don't re-download rpms if they exist on disk added

#2 Updated by mhrivnak about 3 years ago

  • Checklist item Remove the note about a known issue found here: https://github.com/pulp/pulp/pull/2708/files#diff-02b6a9ab33100b00c84a132527f245ddR357 added

#3 Updated by amacdona@redhat.com about 3 years ago

  • Triaged changed from No to Yes

#4 Updated by bmbouter 6 months ago

  • Status changed from NEW to CLOSED - WONTFIX

#5 Updated by bmbouter 6 months ago

Pulp 2 is approaching maintenance mode, and this Pulp 2 ticket is not being actively worked on. As such, it is being closed as WONTFIX. Pulp 2 is still accepting contributions though, so if you want to contribute a fix for this ticket, please reopen or comment on it. If you don't have permissions to reopen this ticket, or you want to discuss an issue, please reach out via the developer mailing list.

#6 Updated by bmbouter 6 months ago

  • Tags Pulp 2 added

Please register to edit this issue

Also available in: Atom PDF