Add option to puppet_install distributor to install to 'modules' directory and cleanup base directory
The current puppet_install distributor installs to whatever path the user specifies. If you are wanting to install to a puppet master you'd have to specify:
However when we delete the repository, the distributor cleanup logic only deletes:
With the current implementation pulp cannot know to safely remove the MYENV directory. One solution would be to provide some option such that the user could just specify
and pulp would automatically populate the modules under ./modules/. Then at delete time pulp could safely delete the MYENV directory.
Updated by mhrivnak about 7 years ago
- Subject changed from Add option to puppet_install distributor to install to 'modules' diretory and cleanup base directory to Add option to puppet_install distributor to install to 'modules' directory and cleanup base directory
From my comment on the associated BZ, regarding the "modules" directory: "I imagine we'd add a setting called something like "create_modules_dir", that would have it create that directory during deployment, and clean it up on removal."
Adding such a setting could allow the distributor to preserve compatibility with existing behavior.
Updated by mhrivnak almost 7 years ago
I think the install_path would be "/etc/puppet/environments/MYENV/"
Then there would be an additional option. It could be:
subdir = 'modules'
in which case pulp would create a subdirectory called "modules" and put stuff in that. It would allow the distributor to be the explicit owner of "/etc/puppet/environments/MYENV/", and thus delete it with confidence during cleanup.
Updated by bmbouter almost 7 years ago
+1 to the subdir option which would default to ''
Link to where the docs should go: http://docs.pulpproject.org/plugins/pulp_puppet/tech-reference/plugin_conf.html#install-distributor
Added by bizhang over 6 years ago
Add subdir option to puppet install distributor
Puppet master modules should be allowed to be installed in a MYENV/modules directory where deleting the puppet repo should remove the MYENV directory. This allows the user to specify a subdir in which modules could be installed.