Task #2106
closed
Pin to flake8 2.6.2
0%
Description
flake8 3.0 drops explicit support for Python 2.6 http://flake8.pycqa.org/en/latest/release-notes/3.0.0.html
In the pulp_python plugin, this caused at least this error:
AttributeError: 'module' object has no attribute 'OrderedDict'
As long as we support el6 (and Python 2.6) we will need to pin flake8 to 2.6.2. This will need to be done in the requirements files for core pulp and each plugin.
Related issues
Updated by amacdona@redhat.com over 8 years ago
- Related to Task #2107: Unpin flake8 version from testing requirements added
Updated by amacdona@redhat.com over 8 years ago
- Platform Release set to 2.8.7
https://github.com/pulp/pulp_python/pull/87
https://github.com/pulp/pulp_python/pull/88
https://github.com/pulp/pulp_rpm/pull/944
https://github.com/pulp/pulp_docker/pull/164
https://github.com/pulp/pulp_ostree/pull/72
https://github.com/pulp/pulp/pull/2657
pulp_puppet didn't get a PR because flake8 does not appear to be run on that project.
Updated by amacdona@redhat.com over 8 years ago
- Platform Release deleted (
2.8.7)
Updated by amacdona@redhat.com over 8 years ago
- Status changed from NEW to POST
- Assignee set to amacdona@redhat.com
Updated by semyers over 8 years ago
Python's PR is open against master. Should it be 1.1-dev?
Updated by amacdona@redhat.com over 8 years ago
Good call, I was only thinking about 2.0 release for the python plugin. I have updated the link.
Updated by semyers over 8 years ago
All LGTM now. Comically, the python PR is failing in travis now because flake8 is working perfectly. :)
Updated by semyers over 8 years ago
...and Jenkies is green on all the PRs now, too, which is excellent.
Updated by amacdona@redhat.com over 8 years ago
- Tracker changed from Issue to Task
- Status changed from POST to MODIFIED
- Platform Release set to 2.10.0
Updated by semyers about 8 years ago
- Status changed from 5 to CLOSED - CURRENTRELEASE
.