Project

Profile

Help

Task #2106

closed

Pin to flake8 2.6.2

Added by amacdona@redhat.com almost 8 years ago. Updated about 5 years ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Category:
-
Sprint/Milestone:
-
Start date:
Due date:
% Done:

0%

Estimated time:
Platform Release:
2.10.0
Groomed:
No
Sprint Candidate:
No
Tags:
Easy Fix, Pulp 2
Sprint:
Quarter:

Description

flake8 3.0 drops explicit support for Python 2.6 http://flake8.pycqa.org/en/latest/release-notes/3.0.0.html

In the pulp_python plugin, this caused at least this error:

 AttributeError: 'module' object has no attribute 'OrderedDict'

As long as we support el6 (and Python 2.6) we will need to pin flake8 to 2.6.2. This will need to be done in the requirements files for core pulp and each plugin.


Related issues

Related to Pulp - Task #2107: Unpin flake8 version from testing requirementsCLOSED - WONTFIX

Actions
Actions #1

Updated by amacdona@redhat.com almost 8 years ago

  • Related to Task #2107: Unpin flake8 version from testing requirements added
Actions #3

Updated by amacdona@redhat.com almost 8 years ago

  • Platform Release deleted (2.8.7)
Actions #4

Updated by amacdona@redhat.com almost 8 years ago

  • Status changed from NEW to POST
  • Assignee set to amacdona@redhat.com
Actions #5

Updated by semyers almost 8 years ago

Python's PR is open against master. Should it be 1.1-dev?

Actions #6

Updated by amacdona@redhat.com almost 8 years ago

Good call, I was only thinking about 2.0 release for the python plugin. I have updated the link.

Actions #7

Updated by semyers almost 8 years ago

All LGTM now. Comically, the python PR is failing in travis now because flake8 is working perfectly. :)

Actions #8

Updated by semyers almost 8 years ago

...and Jenkies is green on all the PRs now, too, which is excellent.

Actions #9

Updated by amacdona@redhat.com almost 8 years ago

  • Tracker changed from Issue to Task
  • Status changed from POST to MODIFIED
  • Platform Release set to 2.10.0
Actions #10

Updated by semyers almost 8 years ago

  • Status changed from MODIFIED to 5
Actions #11

Updated by semyers almost 8 years ago

  • Status changed from 5 to CLOSED - CURRENTRELEASE
Actions #12

Updated by bmbouter about 5 years ago

  • Tags Pulp 2 added

Also available in: Atom PDF