Project

Profile

Help

Refactor #2073

closed

The behavior of the check_publish function does not match its name or description

Added by dalley almost 8 years ago. Updated about 5 years ago.

Status:
CLOSED - WONTFIX
Priority:
Normal
Assignee:
-
Category:
-
Sprint/Milestone:
-
Start date:
Due date:
% Done:

0%

Estimated time:
Platform Release:
Groomed:
No
Sprint Candidate:
No
Tags:
Pulp 2
Sprint:
Quarter:

Description

https://github.com/pulp/pulp/blob/7094ec37cbf5f99194a59a3747447ab874ed2ab2/server/pulp/server/controllers/repository.py#L976

check_publish() is described as checking whether a publish operation should be skipped or not, which it does, but it also then performs a publish itself and returns the result.

All of the publishing logic should be moved to the publish() function in the same module, which should utilize check_publish only to determine if the publish should take place or if it can be skipped.

Also available in: Atom PDF