Project

Profile

Help

Actions
Send by e-mail Copy link

Issue #1853

closed

pulp-puppet-module-builder should not overwrite existing module files

Added by mhrivnak about 8 years ago. Updated about 5 years ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Low
Assignee:
daviddavis
Start date:
Due date:
Estimated time:
Severity:
1. Low
Version:
2.6.0
Platform Release:
2.11.1
OS:
RHEL 7
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
Pulp 2
Sprint:
Sprint 13
Quarter:

Description

From the downstream report:

Issue:
pulp-puppet-module-builder will overwrite existing module files in my --output-dir.  

There is no option to disable this behaviour or emit a warning when it happens. 

Steps to Reproduce:

1. mkdir -p /tmp/example-output
2. cd /tmp/
3. puppet module generate support-example
  take the default responses to all questions
4. cd /tmp/support-example
5. pulp-puppet-module-builder --output-dir=/tmp/example-output
6. sha1sum /tmp/example-output/support-example-0.1.0.tar.gz
Alter the content of /tmp/support-example/manifests/init.pp in some valid way
7. cd /tmp/support-example
8. pulp-puppet-module-builder --output-dir=/tmp/example-output
9. sha1sum /tmp/example-output/support-example-0.1.0.tar.gz

Actual results:
The content of /tmp/example-output/support-example-0.1.0.tar.gz from Step 5 was replaced by Step 8 but no notice was provided.

Expected results:
It would be helpful if there was notice provided and a switch added to prevent overwriting existing module files.

We may need some discussion to decide what the right behavior is.

Actions
Send by e-mail Copy link

Also available in: Atom PDF