Project

Profile

Help

Issue #1820

closed

Fix checking for config.proxy_username

Added by rbarlow about 8 years ago. Updated almost 3 years ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Assignee:
Start date:
Due date:
Estimated time:
Severity:
2. Medium
Version - Nectar:
Platform Release:
2.8.5
Target Release - Nectar:
master
OS:
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
Pulp 2
Sprint:
Quarter:

Description

We received a GitHub pull request with a fix for this issue before the issue was filed, and the pull request is already merged. I am filing it here as well so we can track that we have an unreleased bug fix.

https://github.com/pulp/nectar/pull/47

The rest of this description is quoted from the pull request.

When using basic authentication for the url to fetch and using a proxy without authentication, all the authentication gets stripped away when the proxy_username exists in the config file /etc/pulp/server/plugins.conf/yum_importer.json but is empty. This is because in threaded.py the code checks if proxy_username == None, which is untrue (it is an empty string). Since

variable = ''
if variable:
do_something
evaluates works as well, this is the better option in my opinion.

Also available in: Atom PDF