Issue #1820
closed
Fix checking for config.proxy_username
Description
We received a GitHub pull request with a fix for this issue before the issue was filed, and the pull request is already merged. I am filing it here as well so we can track that we have an unreleased bug fix.
https://github.com/pulp/nectar/pull/47
The rest of this description is quoted from the pull request.
When using basic authentication for the url to fetch and using a proxy without authentication, all the authentication gets stripped away when the proxy_username exists in the config file /etc/pulp/server/plugins.conf/yum_importer.json but is empty. This is because in threaded.py the code checks if proxy_username == None, which is untrue (it is an empty string). Since
variable = ''
if variable:
do_something
evaluates works as well, this is the better option in my opinion.
Updated by amacdona@redhat.com about 8 years ago
- Triaged changed from No to Yes
- Tags Documentation added
Updated by semyers about 8 years ago
- Platform Release changed from 2.8.2 to 2.8.3
Updated by semyers almost 8 years ago
- Status changed from 5 to CLOSED - CURRENTRELEASE
Updated by semyers almost 8 years ago
- Status changed from CLOSED - CURRENTRELEASE to MODIFIED
- Platform Release deleted (
2.8.3)
This got caught up in my 2.8.3 release workflow even though it's a nectar change. It looks like 1.5.1 is the latest nectar release, and does not contain this change, so it really is not in 2.8.3. It won't be in any version of pulp until a new version of nectar is built and pulp's dependencies are updated to use it.
Updated by semyers almost 8 years ago
- Platform Release changed from 2.8.4 to 2.8.5
Updated by semyers almost 8 years ago
- Status changed from 5 to CLOSED - CURRENTRELEASE
.