Project

Profile

Help

Issue #1710

enable-v2 cannot be updated using the CLI

Added by amacdona@redhat.com over 4 years ago. Updated over 1 year ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Assignee:
Start date:
Due date:
Estimated time:
Severity:
2. Medium
Version - Docker:
Platform Release:
Target Release - Docker:
2.0.0
OS:
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
Pulp 2
Sprint:
Quarter:

Description

We can specify `enable-v2` at docker repo creation time, but we cannot update it later. A similar setting, enable-v1 does exist on update.

(pulp)[vagrant@dev pulp]$ pulp-admin docker repo update --repo-id=busybox --enable-v1=False
This command may be exited via ctrl+c without affecting the request.

[\]
Running...

Task Succeeded

(pulp)[vagrant@dev pulp]$ pulp-admin docker repo update --repo-id=busybox --enable-v2=False
Command: update
Description: changes metadata on an existing repository

...

Cut for brevity

...

The following options were specified but do not exist on the command:
  --enable-v2

Associated revisions

Revision 2d4d2597 View on GitHub
Added by rbarlow over 4 years ago

Allow users to --enable-v{1,2} with repo update.

Our Docker CLI extensions had an oversight where users could not update the --enable-v{1,2} flags on their repositories. This commit fixes that oversight.

https://pulp.plan.io/issues/1710

fixes #1710

Revision 2d4d2597 View on GitHub
Added by rbarlow over 4 years ago

Allow users to --enable-v{1,2} with repo update.

Our Docker CLI extensions had an oversight where users could not update the --enable-v{1,2} flags on their repositories. This commit fixes that oversight.

https://pulp.plan.io/issues/1710

fixes #1710

Revision 2d4d2597 View on GitHub
Added by rbarlow over 4 years ago

Allow users to --enable-v{1,2} with repo update.

Our Docker CLI extensions had an oversight where users could not update the --enable-v{1,2} flags on their repositories. This commit fixes that oversight.

https://pulp.plan.io/issues/1710

fixes #1710

Revision 2d4d2597 View on GitHub
Added by rbarlow over 4 years ago

Allow users to --enable-v{1,2} with repo update.

Our Docker CLI extensions had an oversight where users could not update the --enable-v{1,2} flags on their repositories. This commit fixes that oversight.

https://pulp.plan.io/issues/1710

fixes #1710

History

#1 Updated by rbarlow over 4 years ago

  • Status changed from NEW to ASSIGNED
  • Assignee set to rbarlow
  • Triaged changed from No to Yes

#2 Updated by rbarlow over 4 years ago

It turns out that --enable-v1 doesn't work with update either, so I'm fixing that too. PR almost ready.

#3 Updated by rbarlow over 4 years ago

  • Status changed from ASSIGNED to POST

This PR fixes the issue:

https://github.com/pulp/pulp_docker/pull/141

This PR introduces a pulp-smash test to ensure it stays fixed:

https://github.com/PulpQE/pulp-smash/pull/129

#4 Updated by rbarlow over 4 years ago

  • Status changed from POST to MODIFIED
  • % Done changed from 0 to 100

#5 Updated by dkliban@redhat.com over 4 years ago

  • Status changed from MODIFIED to 5

#6 Updated by rbarlow over 4 years ago

  • Status changed from 5 to 6

Tested in the pulp smash PR referenced above.

#7 Updated by dkliban@redhat.com over 4 years ago

  • Status changed from 6 to CLOSED - CURRENTRELEASE

#9 Updated by bmbouter over 1 year ago

  • Tags Pulp 2 added

Please register to edit this issue

Also available in: Atom PDF