Project

Profile

Help

Task #1651

Ensure that the upload recipe is correct for pulp-docker 2.0 in the docs

Added by rbarlow over 5 years ago. Updated over 2 years ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Assignee:
Start date:
Due date:
% Done:

100%

Estimated time:
Platform Release:
Target Release - Docker:
2.0.0
Groomed:
Yes
Sprint Candidate:
Yes
Tags:
Documentation, Pulp 2
Sprint:
Quarter:

Description

In performing the work for #1163, I discovered that upload did not work. As a result, I was unable to verify that the upload docs were accurate with pulp-docker 2.0. Rather than hold that effort, I thought it was better to file a ticket to check the docs later, after fixing upload support.


Related issues

Blocked by Docker Support - Issue #1650: Uploading a v1 Docker Image causes AttributeError: 'UploadStep' object has no attribute 'v1_tags'CLOSED - CURRENTRELEASE<a title="Actions" class="icon-only icon-actions js-contextmenu" href="#">Actions</a>

History

#1 Updated by rbarlow over 5 years ago

  • Blocked by Issue #1650: Uploading a v1 Docker Image causes AttributeError: 'UploadStep' object has no attribute 'v1_tags' added

#2 Updated by semyers over 5 years ago

  • Status changed from NEW to ASSIGNED
  • Assignee set to semyers

#3 Updated by semyers over 5 years ago

My busybox save only had two images in it. Rather than chase that, I think it's probably better to make the docs ambiguous, e.g.

diff --git a/docs/user-guide/recipes.rst b/docs/user-guide/recipes.rst
index f64c67b..3d91e31 100644
--- a/docs/user-guide/recipes.rst
+++ b/docs/user-guide/recipes.rst
@@ -70,7 +70,7 @@ Then create a pulp repository and run an upload command with ``pulp-admin``::
     ... completed


-There are now four new images in the pulp repository::
+There are now images in the pulp repository::

     $ pulp-admin docker repo list
     +----------------------------------------------------------------------+
@@ -83,6 +83,11 @@ There are now four new images in the pulp repository::
     Content Unit Counts:
       Docker Image: 4

+.. note::
+
+    The number of images associated with the repository at this point may differ
+    from the number seen above, but should be at least 1 image.

 During an image upload, you can specify the id of an ancestor image
 that should not be uploaded to the repository. In this case, the masked ancestor

#4 Updated by rbarlow over 5 years ago

  • Status changed from ASSIGNED to POST

I applied your patch in my existing PR:

https://github.com/pulp/pulp_docker/pull/133

#5 Updated by rbarlow over 5 years ago

  • Status changed from POST to MODIFIED
  • % Done changed from 0 to 100

#6 Updated by dkliban@redhat.com over 5 years ago

  • Status changed from MODIFIED to 5

#7 Updated by semyers over 5 years ago

  • Status changed from 5 to CLOSED - CURRENTRELEASE

#8 Updated by bmbouter over 2 years ago

  • Tags Pulp 2 added

Please register to edit this issue

Also available in: Atom PDF