Project

Profile

Help

Issue #1514

closed

export ISO split says it takes bytes argument but really takes MB

Added by cduryee about 8 years ago. Updated almost 5 years ago.

Status:
CLOSED - WONTFIX
Priority:
Normal
Assignee:
-
Sprint/Milestone:
-
Start date:
Due date:
Estimated time:
Severity:
1. Low
Version:
Platform Release:
OS:
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
Documentation, Easy Fix, Pulp 2
Sprint:
Quarter:

Description

When exporting an ISO of yum content, you can set iso_size to set how big you want the ISO to be. This is in MB, but some places inside the code say bytes. This leads to confusion :)

For example:

https://github.com/pulp/pulp_rpm/blob/master/docs/tech-reference/export-distributor.rst (correct)

https://github.com/pulp/pulp_rpm/blob/master/plugins/pulp_rpm/plugins/distributors/export_distributor/generate_iso.py#L30 (incorrect)

It is a little redundant, but please make the "in megabytes" part bold in the doc as well, just for additional clarity. I saw the byte math in the doc and incorrectly assumed bytes.

Also available in: Atom PDF