Project

Profile

Help

Issue #1514

export ISO split says it takes bytes argument but really takes MB

Added by cduryee over 5 years ago. Updated over 2 years ago.

Status:
CLOSED - WONTFIX
Priority:
Normal
Assignee:
-
Sprint/Milestone:
-
Start date:
Due date:
Estimated time:
Severity:
1. Low
Version:
Platform Release:
OS:
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
Documentation, Easy Fix, Pulp 2
Sprint:
Quarter:

Description

When exporting an ISO of yum content, you can set iso_size to set how big you want the ISO to be. This is in MB, but some places inside the code say bytes. This leads to confusion :)

For example:

https://github.com/pulp/pulp_rpm/blob/master/docs/tech-reference/export-distributor.rst (correct)

https://github.com/pulp/pulp_rpm/blob/master/plugins/pulp_rpm/plugins/distributors/export_distributor/generate_iso.py#L30 (incorrect)

It is a little redundant, but please make the "in megabytes" part bold in the doc as well, just for additional clarity. I saw the byte math in the doc and incorrectly assumed bytes.

History

#1 Updated by mhrivnak over 5 years ago

  • Triaged changed from No to Yes

#2 Updated by bmbouter over 2 years ago

  • Status changed from NEW to CLOSED - WONTFIX

Pulp 2 is approaching maintenance mode, and this Pulp 2 ticket is not being actively worked on. As such, it is being closed as WONTFIX. Pulp 2 is still accepting contributions though, so if you want to contribute a fix for this ticket, please reopen or comment on it. If you don't have permissions to reopen this ticket, or you want to discuss an issue, please reach out via the developer mailing list.

#3 Updated by bmbouter over 2 years ago

  • Tags Pulp 2 added

Please register to edit this issue

Also available in: Atom PDF