Actions
Task #1433
closed
Combine two functions that are redundant
Status:
CLOSED - WONTFIX
Priority:
Normal
Assignee:
-
Sprint/Milestone:
-
Start date:
Due date:
% Done:
0%
Estimated time:
Platform Release:
Groomed:
No
Sprint Candidate:
No
Tags:
Pulp 2
Sprint:
Quarter:
Description
We have a function and a method that are very likely redundant. They should be de-duplicated and usage of the one removed should be ported to the one that is being kept. The two functions handle the translation of incoming data from users to handle the renaming of field names changed during the mongoengine conversion. The two functions are update_fields_inbound[0] and to_id_dict[1].
[0]: https://github.com/bmbouter/pulp_rpm/blob/2fbaa0221bc9d585067458dd72194ced15078e50/plugins/pulp_rpm/plugins/importers/yum/upload.py#L38
[1]: https://github.com/bmbouter/pulp_rpm/blob/2fbaa0221bc9d585067458dd72194ced15078e50/plugins/pulp_rpm/plugins/db/models.py#L68
Actions
.