Project

Profile

Help

Task #1433

Combine two functions that are redundant

Added by bmbouter almost 5 years ago. Updated over 1 year ago.

Status:
CLOSED - WONTFIX
Priority:
Normal
Assignee:
-
Sprint/Milestone:
-
Start date:
Due date:
% Done:

0%

Estimated time:
Platform Release:
Groomed:
No
Sprint Candidate:
No
Tags:
Pulp 2
Sprint:
Quarter:

Description

We have a function and a method that are very likely redundant. They should be de-duplicated and usage of the one removed should be ported to the one that is being kept. The two functions handle the translation of incoming data from users to handle the renaming of field names changed during the mongoengine conversion. The two functions are update_fields_inbound[0] and to_id_dict[1].

[0]: https://github.com/bmbouter/pulp_rpm/blob/2fbaa0221bc9d585067458dd72194ced15078e50/plugins/pulp_rpm/plugins/importers/yum/upload.py#L38
[1]: https://github.com/bmbouter/pulp_rpm/blob/2fbaa0221bc9d585067458dd72194ced15078e50/plugins/pulp_rpm/plugins/db/models.py#L68

History

#1 Updated by bmbouter almost 5 years ago

  • Description updated (diff)

#2 Updated by mhrivnak over 4 years ago

  • Sprint Candidate changed from Yes to No

#3 Updated by bmbouter over 1 year ago

  • Status changed from NEW to CLOSED - WONTFIX

Pulp 2 is approaching maintenance mode, and this Pulp 2 ticket is not being actively worked on. As such, it is being closed as WONTFIX. Pulp 2 is still accepting contributions though, so if you want to contribute a fix for this ticket, please reopen or comment on it. If you don't have permissions to reopen this ticket, or you want to discuss an issue, please reach out via the developer mailing list.

#4 Updated by bmbouter over 1 year ago

  • Tags Pulp 2 added

Please register to edit this issue

Also available in: Atom PDF