Project

Profile

Help

Issue #1289

closed

install distributor does not normalize file permissions and ownership

Added by mhrivnak over 8 years ago. Updated about 5 years ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
High
Assignee:
Start date:
Due date:
Estimated time:
Severity:
2. Medium
Version:
2.6.3
Platform Release:
2.8.0
OS:
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
Pulp 2
Sprint:
Quarter:

Description

When the install distributor extracts puppet modules from their tarballs, it does not make any attempt to normalize the file permissions of the files contained in the tarball. This can lead to at least three types of problems:

1. A file cannot be read by puppet.
2. Extracted files cannot be moved by pulp from the temporary extraction area to the permanent destination.
3. A file may have unsafe permissions, such as being world-writable.

Pulp should choose a standard way to normalize these permissions, perhaps ensuring that at a minimum the owner can rwx, and the world can r (and x for directories).

Actions #1

Updated by mhrivnak over 8 years ago

  • Triaged changed from No to Yes
Actions #3

Updated by mhrivnak over 8 years ago

  • Subject changed from install distributor does not normalize file permissions to install distributor does not normalize file permissions and ownership
  • Priority changed from Normal to High
Actions #5

Updated by mhrivnak over 8 years ago

  • Status changed from NEW to ASSIGNED
  • Assignee set to mhrivnak

Added by mhrivnak over 8 years ago

Revision cef8643c | View on GitHub

Install distributor now normalizes uid, gid, and filesystem permissions.

Also resurrected a bunch of unit tests for the install distributor that had been removed during the mongoengine conversion.

fixes #1289

Actions #6

Updated by mhrivnak over 8 years ago

  • Status changed from ASSIGNED to POST
Actions #7

Updated by mhrivnak over 8 years ago

  • Status changed from POST to MODIFIED
  • % Done changed from 0 to 100
Actions #8

Updated by rbarlow about 8 years ago

  • Status changed from MODIFIED to 5
Actions #9

Updated by dkliban@redhat.com about 8 years ago

  • Status changed from 5 to CLOSED - CURRENTRELEASE
Actions #12

Updated by bmbouter about 5 years ago

  • Tags Pulp 2 added

Also available in: Atom PDF