Project

Profile

Help

Story #1145

As a user, I am assured that Pulp is downloading the correct manifests

Added by rbarlow about 5 years ago. Updated over 1 year ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Assignee:
-
Start date:
Due date:
% Done:

100%

Estimated time:
Platform Release:
Target Release - Docker:
2.0.0
Groomed:
No
Sprint Candidate:
Yes
Tags:
Pulp 2
Sprint:
Quarter:

Description

The docker manifests have a digest, which is supposed to be a checksum of the manifest. However, the manifest checksum is not calculated on the downloaded manifest but on some permutation of the manifest. The necessary permutation is not known to the Pulp team at this time, so part of this effort will be determining how to calculate the checksum of the digest. There is a GitHub issue[0] with some information that may be useful. Hint: It may be related to removing signatures, but I am not sure.

Deliverables:

  • Determine how to calculate the digest of the manifest, since the manifest as presented has a different checksum than the given digest from the registry.
  • Rework the Importer to validate the digest of the downloaded manifests to ensure that the expected data was received
  • Consider whether this should be a setting or not (I lean towards not). If you determine that it should, make sure pulp-admin supports it
  • Tests
  • Documentation

[0] https://github.com/docker/docker/issues/8093


Related issues

Blocked by Docker Support - Story #968: As a user, I can sync from a v2 registryCLOSED - CURRENTRELEASE

<a title="Actions" class="icon-only icon-actions js-contextmenu" href="#">Actions</a>
Blocks Docker Support - Task #1048: Tracker for Docker v2 API and Manifest workCLOSED - CURRENTRELEASE

<a title="Actions" class="icon-only icon-actions js-contextmenu" href="#">Actions</a>

Associated revisions

Revision a11e0b15 View on GitHub
Added by rbarlow almost 5 years ago

Add the ability for users to be able to sync from other Pulp servers.

This commit adds code that can calculate the digest of a raw JSON manifest. This allows users to sync from feed URLs that do not provide the digest header, and it also allows Pulp to verify the digest of manifests downloaded from feed URLs that do provide the header.

https://pulp.plan.io/issues/1145 https://pulp.plan.io/issues/1316

closes #1145 closes #1316

Revision a11e0b15 View on GitHub
Added by rbarlow almost 5 years ago

Add the ability for users to be able to sync from other Pulp servers.

This commit adds code that can calculate the digest of a raw JSON manifest. This allows users to sync from feed URLs that do not provide the digest header, and it also allows Pulp to verify the digest of manifests downloaded from feed URLs that do provide the header.

https://pulp.plan.io/issues/1145 https://pulp.plan.io/issues/1316

closes #1145 closes #1316

Revision a11e0b15 View on GitHub
Added by rbarlow almost 5 years ago

Add the ability for users to be able to sync from other Pulp servers.

This commit adds code that can calculate the digest of a raw JSON manifest. This allows users to sync from feed URLs that do not provide the digest header, and it also allows Pulp to verify the digest of manifests downloaded from feed URLs that do provide the header.

https://pulp.plan.io/issues/1145 https://pulp.plan.io/issues/1316

closes #1145 closes #1316

Revision a11e0b15 View on GitHub
Added by rbarlow almost 5 years ago

Add the ability for users to be able to sync from other Pulp servers.

This commit adds code that can calculate the digest of a raw JSON manifest. This allows users to sync from feed URLs that do not provide the digest header, and it also allows Pulp to verify the digest of manifests downloaded from feed URLs that do provide the header.

https://pulp.plan.io/issues/1145 https://pulp.plan.io/issues/1316

closes #1145 closes #1316

History

#1 Updated by rbarlow about 5 years ago

  • Blocked by Story #968: As a user, I can sync from a v2 registry added

#2 Updated by rbarlow about 5 years ago

  • Description updated (diff)

#3 Updated by rbarlow about 5 years ago

  • Blocks Task #1048: Tracker for Docker v2 API and Manifest work added

#4 Updated by rbarlow almost 5 years ago

  • Status changed from NEW to MODIFIED
  • % Done changed from 0 to 100

#5 Updated by mhrivnak almost 5 years ago

  • Target Release - Docker set to 2.0.0

#6 Updated by rbarlow over 4 years ago

  • Status changed from MODIFIED to 5

#7 Updated by dkliban@redhat.com over 4 years ago

  • Status changed from 5 to CLOSED - CURRENTRELEASE

#8 Updated by bmbouter over 1 year ago

  • Tags Pulp 2 added

Please register to edit this issue

Also available in: Atom PDF