Project

Profile

Help

Story #4244

Updated by ipanova@redhat.com over 4 years ago

h2. *Problem:* 

 When pulling newer format manifest by tag old clients are not supported. 

 h2. *Solution:* 

 Rewrite available manifest to schema1 to support old clients. 

 h2. *Workflow:* 

 Fetch the available manifest from the storage backend, if it exists. Parse incoming accept headers from client (client indicates support for certain manifest formats) and if necessary rewrite manifest when it is being fetched by tag. If it is being fetched by digest, conversion is not possible. 

 * If available manifest is a manifest list -    within the manifest list find the image manifest corresponding to the default platform and arch (amd64 platform and linux OS). If no suitable manifest is found in the manifest list, return a 404 error. 
 If necessary( based on incoming accept headers), convert the image manifest to schema1. Invoke Schema1ManifestBuilder to create skeleton of schema1 format. Populate the builder with the data incoming from parsed image manifest schema2 json. 
 Sign schema1 manifest with the provided signing key (in config). If no signing key is provided generate an ephemeral rsa key to be used for signing converted manifests. 

 * If available manifest is a manifest schema2 , if necessary( based on incoming accept headers), convert the image manifest to schema1. 

 * If available manifest is a manifest schema1, return as is. 

 h3. +Signed Manifest Field Description+ 

 Signed manifests include an image manifest and a list of signatures. A signature consists of the following fields: 

     header JOSE 

     A JSON Web Signature 

     signature string 

     A signature for the image manifest, signed by a private key 

     protected string 

     The signed protected header 

 h3. +Optional conversion+ 

 The conversion will be optional. There will be a boolean flag called for example 'schema_conversion` added    as a parameter to the docker distribution [0] where its default value would be set to False. 
 Conversion would happen only if enabled. 

 [0]    https://github.com/pulp/pulp_docker/blob/master/pulp_docker/app/models.py#L297 
 https://docs.docker.com/registry/spec/manifest-v2-2/#backward- 

 h3. +Opened questions:+ 

 Do we convert manifest schema2 if it had foreign layers? 

Back