Backport #9612: Backport #8968 "'NoneType' object has no attribute 'delete'" during migration to 0.11.z - Migration Plugin - Pulp

Actions

Send by e-mail Copy link

Backport #9612

closed

Backport #8968 "'NoneType' object has no attribute 'delete'" during migration to 0.11.z

Added by ttereshc almost 3 years ago. Updated almost 3 years ago.

Status:

MODIFIED

Priority:

Normal

Assignee:

Sprint/Milestone:

0.11.7

Start date:

Due date:

% Done:

100%

Estimated time:

Triaged:

Sprint Candidate:

Tags:

Katello

Sprint:

Sprint 111

Quarter:

Description

Backtrace:

"error"=>
     {"traceback"=>
       "  File \"/usr/lib/python3.6/site-packages/rq/worker.py\", line 936, in perform_job\n" +
       "    rv = job.perform()\n" +
       "  File \"/usr/lib/python3.6/site-packages/rq/job.py\", line 684, in perform\n" +
       "    self._result = self._execute()\n" +
       "  File \"/usr/lib/python3.6/site-packages/rq/job.py\", line 690, in _execute\n" +
       "    return self.func(*self.args, **self.kwargs)\n" +
       "  File \"/usr/lib/python3.6/site-packages/pulp_2to3_migration/app/tasks/migrate.py\", line 76, in migrate_from_pulp2\n" +
       "    pre_migrate_all_without_content(plan)\n" +
       "  File \"/usr/lib/python3.6/site-packages/pulp_2to3_migration/app/pre_migration.py\", line 493, in pre_migrate_all_without_content\n" +
       "    pre_migrate_importer(repo_id, importer_types)\n" +
       "  File \"/usr/lib/python3.6/site-packages/pulp_2to3_migration/app/pre_migration.py\", line 601, in pre_migrate_importer\n" +
       "    importer.pulp3_remote.delete()\n",
      "description"=>"'NoneType' object has no attribute 'delete'"},
    "worker"=>"/pulp/api/v3/workers/fc6ba1d6-ddc6-494d-9385-2368544a09ef/",

This happened on Katello 3.18.3 which uses:

pulp-2to3-migration (0.11.1)
pulp-certguard (1.0.3)
pulp-container (2.1.2)
pulp-deb (2.7.0)
pulp-file (1.3.0)
pulp-rpm (3.10.0)
pulpcore (3.7.6)

Related issues

Actions

Copy link

Updated by ttereshc almost 3 years ago

Copied from Issue #8968: "'NoneType' object has no attribute 'delete'" during migration added

Added by ttereshc almost 3 years ago

Revision 2c1f6007 | View on GitHub

Guard pulp3_remote from importer clearing

backports #8968 https://pulp.plan.io/issues/8968

We have hit the above issue while 2to3 migrating SLES importers. Apparently this is sometimes called for SLES importers that already have their pulp3_remote set to None, resulting in:

'NoneType' object has no attribute 'delete'

We did not perform any deeper analysis of why this is the case, but simply added this guard to fix the problem.

fixes #9612

(cherry picked from commit b8892d7d15317b5e46ef568bc6c2ccbddacb46b0)

Added by ttereshc almost 3 years ago

Revision 2c1f6007 | View on GitHub

Guard pulp3_remote from importer clearing

backports #8968 https://pulp.plan.io/issues/8968

We have hit the above issue while 2to3 migrating SLES importers. Apparently this is sometimes called for SLES importers that already have their pulp3_remote set to None, resulting in:

'NoneType' object has no attribute 'delete'

We did not perform any deeper analysis of why this is the case, but simply added this guard to fix the problem.

fixes #9612

(cherry picked from commit b8892d7d15317b5e46ef568bc6c2ccbddacb46b0)

Actions

Copy link