Project

Profile

Help

Issue #9095

closed

pulp_installer preflight check is typically not being run when pulp-rpm is being installed

Added by mdepaulo@redhat.com about 1 year ago. Updated about 1 year ago.

Status:
MODIFIED
Priority:
Normal
Category:
Installer - Moved to GitHub issues
Sprint/Milestone:
Start date:
Due date:
Estimated time:
Severity:
2. Medium
Version:
Platform Release:
OS:
Triaged:
No
Groomed:
No
Sprint Candidate:
No
Tags:
Sprint:
Quarter:

Description

This appears to a regression from #6799 .

It's a bug in the logic, we want to run 2 preflight checks (before and after the prereq_role is loaded).

For the "before" check:

Instead of checking for either pulp-rpm being in pulp_install_plugins (the common use case now) or any plugin having a prereq_role (extremely uncommon now), we check for both of those things happening. We use an "and" rather than an "or".

For the "after" check:

We only check for a plugin having a "prereq_role". We should also check for pulp-rpm being in pulp_install_plugins (the common use case now)

Actions #1

Updated by mdepaulo@redhat.com about 1 year ago

  • Subject changed from pulp_installer preflight check is not being run when pulp-rpm is being installed to pulp_installer preflight check is typically not being run when pulp-rpm is being installed
  • Description updated (diff)

Added by Mike DePaulo about 1 year ago

Revision 1754af5e

Problem: pulp_installer preflight check is

typically not being run when pulp-rpm is being installed

Solution: Ensure that the check is for either pulp-rpm being in the list or the nested variable prereq_role is specified.

fixes: #9095

Added by Mike DePaulo about 1 year ago

Revision 1754af5e

Problem: pulp_installer preflight check is

typically not being run when pulp-rpm is being installed

Solution: Ensure that the check is for either pulp-rpm being in the list or the nested variable prereq_role is specified.

fixes: #9095

Actions #2

Updated by pulpbot about 1 year ago

  • Status changed from NEW to POST
Actions #3

Updated by Anonymous about 1 year ago

  • Status changed from POST to MODIFIED
Actions #4

Updated by mdepaulo@redhat.com about 1 year ago

  • Sprint/Milestone set to 3.14.3

Also available in: Atom PDF