Project

Profile

Help

Refactor #8635

Deprecate ContentUnassociation stage

Added by dalley 5 months ago. Updated 4 months ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Assignee:
Category:
-
Sprint/Milestone:
Start date:
Due date:
% Done:

100%

Estimated time:
Platform Release:
Groomed:
No
Sprint Candidate:
No
Tags:
Sprint:
Quarter:

Description

ContentUnassociation doesn't really need to be a separate stage, and making it one breaks the expectations of the "pipeline" by changing the semantics of what goes into and out of the queues.

The ContentAssociation stage puts querysets into the queue (instead of declarative content) for the sake of the ContentUnassociation stage, and also these querysets represent content to remove rather than content to add.

Furthermore this isn't necessary. Rather than toggling whether the ContentUnassociation stage is run as a whole, we can just pass a boolean parameter into the ContentAssociation stage to toggle the behavior.


Related issues

Copied to Pulp - Refactor #8827: Remove ContentUnassociation stageCLOSED - CURRENTRELEASE

<a title="Actions" class="icon-only icon-actions js-contextmenu" href="#">Actions</a>

Associated revisions

Revision 0ae327ab View on GitHub
Added by dalley 5 months ago

Merge ContentUnassociation stage into the ContentAssociation stage

ContentUnassociation doesn't really need to be a separate stage, and making it one breaks the expectations of the "pipeline" by changing the semantics of what goes into and out of the queues.

closes: #8635 https://pulp.plan.io/issues/8635

Revision 1db09595 View on GitHub
Added by dalley 5 months ago

Revert "Merge ContentUnassociation stage into the ContentAssociation stage"

Reverts commits: ec7afd2f5e34acacf40c1b59637438339dc56584 0ae327ab5de95020b97f9438f090849760ef8272

re: #8635 https://pulp.plan.io/issues/8635

Revision 776f530e View on GitHub
Added by dalley 5 months ago

Deprecate ContentUnassociation stage

re: #8635 https://pulp.plan.io/issues/8635

History

#1 Updated by dalley 5 months ago

  • Status changed from ASSIGNED to POST

#2 Updated by dalley 5 months ago

  • Status changed from POST to MODIFIED
  • % Done changed from 0 to 100

#3 Updated by dalley 5 months ago

  • Status changed from MODIFIED to NEW

Reverting to move to 3.14 after a deprecation cycle

#4 Updated by pulpbot 5 months ago

  • Status changed from NEW to POST

#6 Updated by dalley 4 months ago

  • Status changed from POST to ASSIGNED

#7 Updated by dalley 4 months ago

  • Subject changed from Merge ContentUnassociation stage into ContentAssociation stage to Deprecate ContentUnassociation stage
  • Status changed from ASSIGNED to MODIFIED

#8 Updated by dalley 4 months ago

  • Sprint/Milestone set to 3.13.0

#9 Updated by pulpbot 4 months ago

  • Status changed from MODIFIED to CLOSED - CURRENTRELEASE

#10 Updated by dalley 4 months ago

Please register to edit this issue

Also available in: Atom PDF