Project

Profile

Help

Issue #6520

closed

Regression: publishing an empty ISO repo no longer publishes PULP_MANIFEST

Added by ipanova@redhat.com about 2 years ago. Updated almost 2 years ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Assignee:
-
Category:
-
Sprint/Milestone:
-
Start date:
Due date:
Estimated time:
Severity:
2. Medium
Version:
Platform Release:
2.21.2
OS:
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
Pulp 2
Sprint:
Quarter:

Description

I don't think this is fixed.

Debugging log is added as below:

_logger.error(publish_conduit.last_publish)

The output is:

Mar 18 08:30:26 pulp-05 pulp: pulp.plugins.file.distributor:ERROR: [8a3e0c82] <bound method RepoPublishConduit.last_publish of <pulp.plugins.conduits.repo_publish.RepoPublishConduit object at 0x7f62bc372510>>

It's always not None. So publish is still fast forward when repo has never been published.

Added by yuzheng about 2 years ago

Revision 2403d7dd

Fix last_publish method call

Method last_publish was not called properly so that a bound method was used instead of its return. It made publish always be fast-forward no matter repo has been published or not when force_full=True is not set.

Closes #5659

Added by yuzheng about 2 years ago

Revision 8bf831f8

Fix last_publish method call

Method last_publish was not called properly so that a bound method was used instead of its return. It made publish always be fast-forward no matter repo has been published or not when force_full=True is not set.

Added new case for testing this and fixed tests added before.

Closes #5659

Actions #1

Updated by ipanova@redhat.com about 2 years ago

  • Project changed from RPM Support to Pulp
  • Status changed from NEW to POST
  • Tags Pulp 2 added
Actions #2

Updated by ipanova@redhat.com about 2 years ago

  • Status changed from POST to MODIFIED
Actions #3

Updated by ipanova@redhat.com about 2 years ago

  • Triaged changed from No to Yes
Actions #4

Updated by dalley about 2 years ago

  • Platform Release set to 2.21.2
Actions #5

Updated by dalley about 2 years ago

  • Status changed from MODIFIED to 5
Actions #6

Updated by dalley about 2 years ago

  • Status changed from 5 to CLOSED - CURRENTRELEASE

Also available in: Atom PDF