Project

Profile

Help

Issue #6411

closed

Sync fails to optimize on second sync to new remote when no repo version is created

Added by CodeHeeler over 2 years ago. Updated over 2 years ago.

Status:
CLOSED - WONTFIX
Priority:
Normal
Assignee:
-
Sprint/Milestone:
-
Start date:
Due date:
Estimated time:
Severity:
2. Medium
Version:
Platform Release:
OS:
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
Sprint:
Quarter:

Description

Full sync should take place when a repo is synced with a new remote. After that first sync to the new remote, barring other changes, the second and subsequent syncs to this remote should be optimized.

That is not happening if the new remote uses the same url as the previous remote. Instead, if no new repository version was created after the previous sync and the new remote was created after the initial repository version was created, the full sync takes place without optimization. That takes place here when this check fails and thus optimization is skipped: https://github.com/pulp/pulp_rpm/blob/master/pulp_rpm/app/tasks/synchronizing.py#L341

You can see this take place with the existing tests if you remove the line that gives the new remote a different url:

body['url'] = RPM_RICH_WEAK_FIXTURE_URL

As seen here: https://github.com/pulp/pulp_rpm/pull/1654/files#diff-8f32cf66253dff95174204c7550ff234R577

Actions #1

Updated by CodeHeeler over 2 years ago

  • Description updated (diff)
Actions #2

Updated by CodeHeeler over 2 years ago

  • Description updated (diff)
Actions #3

Updated by CodeHeeler over 2 years ago

  • Description updated (diff)
Actions #4

Updated by ttereshc over 2 years ago

  • Status changed from NEW to CLOSED - WONTFIX
  • Triaged changed from No to Yes

That's a rare case when 2 remotes have exactly the same content and sync is run for those 2 remotes sequentially. There is no correctness problem here, just no optimisation in this specific case.

If you feel that it's important to fix it, feel free to re-open this issue or to file a new one.

Also available in: Atom PDF