Task #6150
closed
plugin-template needs to let plugins add new Travis services
100%
Description
pulp-2to3-migration had to resort to manually modifying .travis.yml:
services:
- postgresql
- redis-server
- docker
# This line manually added until the plugin-template makes this configurable.
- mongodb
Because the services list was non-configurable.
2 ways of doing this:
- Make the entire service list a variable. This is more flexible, but makes it more likely to be out-of-date in the future (and thus CI fails) when other parts of the travis template start needing new services.
- Create a variable list of services that get appended to the normal list of services. The only downside is that we might have plugin devs might specify service foo, but it later becomes a fixed service, and gets listed 2x. Duplicates might break Travis, but we could also deduplicate it in Python logic.
Added by Mike DePaulo about 4 years ago
Updated by Anonymous about 4 years ago
- Status changed from NEW to MODIFIED
- % Done changed from 0 to 100
Applied in changeset plugin_template|25ffdcd8d438292367c9ea63e3ca43ca49741e07.
Added by Mike DePaulo about 4 years ago
Revision e27faa33 | View on GitHub
Problem: .travis.yml was modified manually
Solution: Re-generate with latest plugin-template, after adding mongodb to travis_addtl_services
re: #6150 Task: plugin-template needs to let plugins add new Travis services https://pulp.plan.io/issues/6150
[noissue]
Added by Mike DePaulo about 4 years ago
Revision e27faa33 | View on GitHub
Problem: .travis.yml was modified manually
Solution: Re-generate with latest plugin-template, after adding mongodb to travis_addtl_services
re: #6150 Task: plugin-template needs to let plugins add new Travis services https://pulp.plan.io/issues/6150
[noissue]
Added by Mike DePaulo about 4 years ago
Revision e27faa33 | View on GitHub
Problem: .travis.yml was modified manually
Solution: Re-generate with latest plugin-template, after adding mongodb to travis_addtl_services
re: #6150 Task: plugin-template needs to let plugins add new Travis services https://pulp.plan.io/issues/6150
[noissue]
Updated by mdepaulo@redhat.com about 4 years ago
- Status changed from MODIFIED to CLOSED - COMPLETE
.
Task: plugin-template needs to let plugins add new Travis services
Solution: Create a variable list of services that get appended to the normal list of services.
This approach makes things easy for plugin devs, and prevents them from overlooking adding new services that the rest of the template needs, and running into CI failure because of it.
The only downside is that we might have plugin devs might specify service foo, but it later becomes a fixed service, and gets listed 2x. Duplicates might break Travis, but we could also deduplicate it in Python logic.
fixes: #6150