Project

Profile

Help

Actions
Send by e-mail Copy link

Refactor #4593

closed

rename certguard type to x509

Added by amacdona@redhat.com about 5 years ago. Updated over 3 years ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Assignee:
bmbouter
Sprint/Milestone:
1.0.0 Release
Start date:
Due date:
% Done:

100%

Estimated time:
Platform Release:
Groomed:
Yes
Sprint Candidate:
No
Tags:
Sprint:
Sprint 51
Quarter:

Description

IMO the call to make a new x509 certguard would make more sense if it was:

http://localhost:8000/pulp/api/v3/contentguards/certguard/x509/

instead of

http://localhost:8000/pulp/api/v3/contentguards/certguard/certguard/
Actions
Copy link
 #1

Updated by bmbouter about 5 years ago

  • Status changed from NEW to ASSIGNED
  • Assignee set to bmbouter
  • Sprint set to Sprint 51

+1 to this story @asmacdo.

Actions
Copy link
 #2

Updated by bmbouter about 5 years ago

  • Groomed changed from No to Yes
Actions
Copy link
 #3

Updated by bmbouter about 5 years ago

  • Subject changed from rename certguard type to x509 to rename certguard type to X.509
  • Description updated (diff)

Switchiing to its formal name: X.509

Actions
Copy link
 #4

Updated by bmbouter about 5 years ago

  • Subject changed from rename certguard type to X.509 to rename certguard type to x509
  • Description updated (diff)

Actually openssl uses this shorthand so I'll use it too.

Actions
Copy link
 #5

Updated by bmbouter about 5 years ago

  • Status changed from ASSIGNED to POST
Actions
Copy link
 #6

Updated by bmbouter about 5 years ago

  • Description updated (diff)

This PR is ready, but the problem with the URL that ends in 'certguard/x509/' is that it still reserves the model TYPE as 'certguard' when really that is x509 also. This means the sane URL to use (and not occupy the generic term certguard correctly) is 'x509/x509'. Overall the master detail URL structure I think is causing this to not be as awesome, but I believe 'x509/x509' is better than 'certguard/certguard' so I'm +1 to this change.

Rewriting description because of it.

Actions
Copy link
 #7

Updated by bmbouter about 5 years ago

  • Description updated (diff)

Actually the name is not determined by the TYPE, it's the app name so it will be certguard/x509 which is great.

Added by bmbouter about 5 years ago

Revision bd173cac | View on GitHub

Updates x509 certguard URL

The name being x509 makes more sense than certguard.

https://pulp.plan.io/issues/4593 closes #4593

Actions
Copy link
 #8

Updated by bmbouter about 5 years ago

  • Status changed from POST to MODIFIED
  • % Done changed from 0 to 100
Actions
Copy link
 #9

Updated by bmbouter about 5 years ago

  • Sprint/Milestone set to 1.0.0 Release
Actions
Copy link
 #10

Updated by bmbouter almost 5 years ago

  • Tags deleted (Pulp 3)
Actions
Copy link
 #11

Updated by bmbouter over 3 years ago

  • Status changed from MODIFIED to CLOSED - CURRENTRELEASE
Actions
Send by e-mail Copy link

Also available in: Atom PDF