Project

Profile

Help

Send by e-mail

Task #4500

Collect test coverage from rq workers

Added by daviddavis about 2 years ago. Updated almost 2 years ago.

Status:
NEW
Priority:
Normal
Assignee:
-
Category:
-
Sprint/Milestone:
-
Start date:
Due date:
% Done:

0%

Estimated time:
Platform Release:
Groomed:
No
Sprint Candidate:
No
Tags:
Sprint:
Quarter:

Description

This is a task to revisit this PR:

https://github.com/pulp/pulpcore/pull/10

We had to revert these changes because it doubled the build time from 20 to 40 min.

Related issues

Related to Pulp - Issue #4499: Pulpcore Travis builds are taking twice as long (40 min vs 20 min)CLOSED - CURRENTRELEASE<a title="Actions" class="icon-only icon-actions js-contextmenu" href="#">Actions</a>
Related to Pulp - Refactor #4416: Gather coverage from Content app for test purposesCLOSED - WONTFIX

<a title="Actions" class="icon-only icon-actions js-contextmenu" href="#">Actions</a>

History

#1 Updated by daviddavis about 2 years ago

  • Related to Issue #4499: Pulpcore Travis builds are taking twice as long (40 min vs 20 min) added

#2 Updated by amacdona@redhat.com about 2 years ago

I like the idea of running this nightly instead of each PR. That will do less for encouraging high coverage, but we were mostly ignoring that anyway.

#3 Updated by daviddavis about 2 years ago

  • Related to Refactor #4416: Gather coverage from Content app for test purposes added

#4 Updated by bmbouter about 2 years ago

I asked about this to the RQ community in their issue tracker here: https://github.com/rq/rq/issues/1051

Their suggestion is to use the SimpleWorker which will run the RQ tasks in the webserver itself synchronously. We could try to have a new worker type pulpcore.tests.functional.worker_with_coverage.CoveragePulpWorker that would use SimpleWorker with our custom worker behaviors from PulpWorker.

#5 Updated by bmbouter almost 2 years ago

  • Tags deleted (Pulp 3)

Please register to edit this issue

Send by e-mail

Also available in: Atom PDF