Project

Profile

Help

Task #4430

Travis issue check doesn't enforce syntax

Added by bmbouter 8 months ago. Updated 6 months ago.

Status:
CLOSED - NOTABUG
Priority:
Normal
Assignee:
-
Category:
-
Sprint/Milestone:
Start date:
Due date:
% Done:

0%

Platform Release:
Blocks Release:
Backwards Incompatible:
No
Groomed:
No
Sprint Candidate:
No
Tags:
QA Contact:
Complexity:
Smash Test:
Verified:
No
Verification Required:
No
Sprint:

Description

A PR from @gmbnomis in its commit message had:

closes: #1234 which would not have associated correctly. Travis allowed it. One possible improvement would be to have it check the exact syntax Redmine uses here: https://docs.pulpproject.org/en/3.0/nightly/contributing/git.html#commit-message

History

#1 Updated by daviddavis 8 months ago

I think that works in Redmine. Here is a commit that uses this syntax:

https://github.com/pulp/pulp/commit/456e6a8c591e079e28361d1471e842d7d9e9381b

And here is the association:

https://pulp.plan.io/issues/4100#note-11

Here is the relevant regex in redmine:

https://git.io/fhd3O

Perhaps we should enforce the style in our docs though—better for consistency and safety.

#2 Updated by bmbouter 8 months ago

  • Status changed from NEW to CLOSED - NOTABUG

David, that sounds good. I think we can close as NOTABUG then.

#3 Updated by daviddavis 6 months ago

  • Sprint/Milestone set to 3.0

#4 Updated by bmbouter 6 months ago

  • Tags deleted (Pulp 3)

Please register to edit this issue

Also available in: Atom PDF