Actions
Task #4430
closed
Travis issue check doesn't enforce syntax
Start date:
Due date:
% Done:
0%
Estimated time:
Platform Release:
Groomed:
No
Sprint Candidate:
No
Tags:
Sprint:
Quarter:
Description
A PR from gmbnomis in its commit message had:
closes: #1234 which would not have associated correctly. Travis allowed it. One possible improvement would be to have it check the exact syntax Redmine uses here: https://docs.pulpproject.org/en/3.0/nightly/contributing/git.html#commit-message
Updated by daviddavis almost 6 years ago
I think that works in Redmine. Here is a commit that uses this syntax:
https://github.com/pulp/pulp/commit/456e6a8c591e079e28361d1471e842d7d9e9381b
And here is the association:
https://pulp.plan.io/issues/4100#note-11
Here is the relevant regex in redmine:
Perhaps we should enforce the style in our docs though—better for consistency and safety.
Updated by bmbouter almost 6 years ago
- Status changed from NEW to CLOSED - NOTABUG
David, that sounds good. I think we can close as NOTABUG then.
Actions
.