Project

Profile

Help

Issue #4372

closed

Fix content docstring

Added by amacdona@redhat.com about 5 years ago. Updated about 4 years ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Assignee:
Sprint/Milestone:
Start date:
Due date:
Estimated time:
Severity:
2. Medium
Platform Release:
OS:
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
Documentation, Easy Fix
Sprint:
Sprint 49
Quarter:

Description

https://github.com/pulp/pulp_file/blob/master/pulp_file/app/models.py#L15

"0 or more" is incorrect. Each FileContent is exactly 1 file.

https://github.com/pulp/pulpcore-plugin/pull/37#discussion_r252740249

Once this is fixed in the file plugin, please update the plugin writer's guide as well where we use the FileContent as an example in (at least) 2 places.

pulpcore-plugin/docs/plugin-writer/concepts/subclassing/models.rst

Actions #1

Updated by amacdona@redhat.com about 5 years ago

  • Tags Documentation, Easy Fix, Pulp 3 added
Actions #2

Updated by CodeHeeler about 5 years ago

  • Triaged changed from No to Yes
  • Sprint set to Sprint 48
Actions #3

Updated by ppicka about 5 years ago

  • Status changed from NEW to ASSIGNED
  • Assignee set to ppicka
Actions #5

Updated by daviddavis about 5 years ago

  • Sprint changed from Sprint 48 to Sprint 49

The PRs were open this sprint so I am bumping this to Sprint 49.

Actions #6

Updated by ppicka about 5 years ago

  • Status changed from POST to MODIFIED

Applied in changeset pulp:commit:pulpcore-plugin|dbac70e38a3552d34f1eff61d0715c6f96bb7de1.

Added by ppicka about 5 years ago

Revision 4c95be21 | View on GitHub

Fix FileContent description in docs

File content is always 1 file. Fixed in models docstring.

re: #4372 https://pulp.plan.io/issues/4372

Required PR: https://github.com/pulp/pulpcore-plugin/pull/61

Signed-off-by: Pavel Picka

Actions #7

Updated by bmbouter almost 5 years ago

  • Tags deleted (Pulp 3)
Actions #8

Updated by bmbouter about 4 years ago

  • Sprint/Milestone set to 0.1.0
Actions #9

Updated by bmbouter about 4 years ago

  • Status changed from MODIFIED to CLOSED - CURRENTRELEASE

Also available in: Atom PDF