Issue #3909
closed
auto_decompress of Downloaders modifies binary data downloaded
Description
If you use the auto_decompress=False option, the file saved by the downloader to the temporary area is expected to be byte-for-byte idential binary data as the remote source. Due to a bug in aiohttp, this is not the case.
This causes DigestValidationErrors to be raised when downloading with DeclarativeVersion because the ArtifactDownloader specifies auto_decompress=False.
This issue is reproduced outside of Pulp and is tracked in upstream aiohttp here: https://github.com/aio-libs/aiohttp/issues/3182
I'm advocating to temporarily disable digest/size validation used by ArtifactDownloader until this issue is resolved.
Updated by CodeHeeler over 6 years ago
- Triaged changed from No to Yes
- Sprint set to Sprint 41
Updated by bmbouter over 6 years ago
- Status changed from NEW to ASSIGNED
- Assignee set to bmbouter
Updated by bmbouter over 6 years ago
- Status changed from ASSIGNED to CLOSED - NOTABUG
This was reproducable by the Python unit tests, but actually the root cause is the content-encoding response from the repos.fedorapeople.com server. I filed as issue for it here: https://pagure.io/fedora-infrastructure/issue/7161
The auto_decompress feature has also been negative committed. I'm closing this as NOTABUG since it's working. The workaround for now is to sync from upstream sources like PyPI instead of fixture data from repos.fedorapeople.com.
.