Project

Profile

Help

Task #3704

closed

Make MasterModel attributes private using leading underscores

Added by bmbouter over 6 years ago. Updated over 5 years ago.

Status:
CLOSED - DUPLICATE
Priority:
Normal
Assignee:
-
Category:
-
Sprint/Milestone:
Start date:
Due date:
% Done:

0%

Estimated time:
Platform Release:
Groomed:
No
Sprint Candidate:
No
Tags:
Sprint:
Quarter:

Description

Motivations

1. Avoiding attribute naming collisions when content writer's subclass Content.

2. Allow users to easily see which attributes are from pulpcore and therefore common to all content types.

Changes

Rename the MasterModel fields here in the following ways:

created -> _created
id -> _id
last_updated -> _last_updated

Also for the Content model itself

notes -> _notes
artifacts -> _artifacts

Details

After making ^ change, go through pulp/pulp and update any references to the old field names. Once Pulp-smash passes w/ the new field names, you're done.

This will be a backwards incompatible Beta change for both plugin writers and users. As such, the PR needs the 'breaking-changes', 'rest-API', and 'plugin-writer' labels.

Actions #1

Updated by bmbouter over 6 years ago

  • Sprint Candidate changed from No to Yes
Actions #2

Updated by bmbouter over 6 years ago

  • Description updated (diff)

Revised after discussion on pulp-dev and on irc

Actions #3

Updated by amacdona@redhat.com over 6 years ago

  • Sprint Candidate changed from Yes to No
Actions #4

Updated by amacdona@redhat.com about 6 years ago

  • Is duplicate of Refactor #4206: Prepend all pulpcore model fields in the Content model hierarchy with _ (e.g. '_type', '_id', '_notes') added
Actions #5

Updated by dalley about 6 years ago

  • Is duplicate of deleted (Refactor #4206: Prepend all pulpcore model fields in the Content model hierarchy with _ (e.g. '_type', '_id', '_notes'))
Actions #6

Updated by dalley about 6 years ago

  • Status changed from NEW to CLOSED - DUPLICATE
Actions #7

Updated by daviddavis over 5 years ago

  • Sprint/Milestone set to 3.0.0
Actions #8

Updated by bmbouter over 5 years ago

  • Tags deleted (Pulp 3)

Also available in: Atom PDF