Task #3704
Make MasterModel attributes private using leading underscores
0%
Description
Motivations¶
1. Avoiding attribute naming collisions when content writer's subclass Content.
2. Allow users to easily see which attributes are from pulpcore and therefore common to all content types.
Changes¶
Rename the MasterModel fields here in the following ways:
created -> _created
id -> _id
last_updated -> _last_updated
Also for the Content model itself
notes -> _notes
artifacts -> _artifacts
Details¶
After making ^ change, go through pulp/pulp and update any references to the old field names. Once Pulp-smash passes w/ the new field names, you're done.
This will be a backwards incompatible Beta change for both plugin writers and users. As such, the PR needs the 'breaking-changes', 'rest-API', and 'plugin-writer' labels.
History
#1
Updated by bmbouter over 2 years ago
- Sprint Candidate changed from No to Yes
#2
Updated by bmbouter over 2 years ago
- Description updated (diff)
Revised after discussion on pulp-dev and on irc
#3
Updated by amacdona@redhat.com over 2 years ago
- Sprint Candidate changed from Yes to No
#4
Updated by amacdona@redhat.com about 2 years ago
- Is duplicate of Refactor #4206: Prepend all pulpcore model fields in the Content model hierarchy with _ (e.g. '_type', '_id', '_notes') added
#5
Updated by dalley about 2 years ago
- Is duplicate of deleted (Refactor #4206: Prepend all pulpcore model fields in the Content model hierarchy with _ (e.g. '_type', '_id', '_notes'))
#6
Updated by dalley about 2 years ago
- Status changed from NEW to CLOSED - DUPLICATE
#7
Updated by daviddavis over 1 year ago
- Sprint/Milestone set to 3.0.0
#8
Updated by bmbouter over 1 year ago
- Tags deleted (
Pulp 3)
Please register to edit this issue