Project

Profile

Help

Task #2683

handle working directories in base PulpTask

Added by amacdona@redhat.com over 2 years ago. Updated 6 months ago.

Status:
CLOSED - NOTABUG
Priority:
Normal
Assignee:
-
Category:
-
Sprint/Milestone:
Start date:
Due date:
% Done:

0%

Platform Release:
Blocks Release:
Backwards Incompatible:
No
Groomed:
No
Sprint Candidate:
No
Tags:
QA Contact:
Complexity:
Smash Test:
Verified:
No
Verification Required:
No
Sprint:

Description

Creation and cleanup of `working_dir` should owned by the `PulpTask` class [0]. Creation of a new `working_dir` should occur on `PulpTask.__call__()` and cleanup should occur on `PulpTask.on_success()` and `PulpTask.on_failure()`.

`PulpTask`'s child, `UserFacingTask` will need to be updated to use super() to pick up this functionality.

[0] - https://github.com/pulp/pulp/blob/3.0-dev/tasking/pulp/tasking/tasks.py#L28

History

#1 Updated by bmbouter over 2 years ago

While working on sync() it was determined that very few tasks actually need working directories and it would be inefficient to have them created/deleted with every Task (which is what this issue is for). It probably is only sync() and publish(). Since those stories include the working dir create+delete we should close this as WONTFIX.

I'm waiting for another dev who agrees to actually close it.

#2 Updated by amacdona@redhat.com over 2 years ago

  • Status changed from NEW to CLOSED - NOTABUG

Agreed. This work is now done by this context manager:
https://github.com/pulp/pulp/blob/8401606b530f6fb712b98fc0359d41a3cb560069/platform/pulp/tasking/services/storage.py#L142

Too bad we don't have a CLOSED-IRRELEVANT :)

#3 Updated by bmbouter over 2 years ago

Thanks @asmacdo.

wrote:

Too bad we don't have a CLOSED-IRRELEVANT :)

hahaha

#4 Updated by daviddavis 6 months ago

  • Sprint/Milestone set to 3.0

#5 Updated by bmbouter 6 months ago

  • Tags deleted (Pulp 3)

Please register to edit this issue

Also available in: Atom PDF