Issue #1538
closed
Nectar's `download_one` should use the same `Session` object for all requests
Description
Nectar currently creates a new `requests.Session`[0] object for every call to `download_one` in the threaded downloader. This fails to take advantage of the Sessions ability to pool TCP connections. Instead, it should probably have a session that is instantiated with the downloader dedicated to the `download_one` method. My guess is that the Session object is not thread-safe, so we cannot use a single session across the downloader. This may be incorrect, though.
[0] http://docs.python-requests.org/en/latest/user/advanced/#session-objects
Updated by bmbouter about 5 years ago
- Status changed from NEW to CLOSED - WONTFIX
Updated by bmbouter about 5 years ago
Pulp 2 is approaching maintenance mode, and this Pulp 2 ticket is not being actively worked on. As such, it is being closed as WONTFIX. Pulp 2 is still accepting contributions though, so if you want to contribute a fix for this ticket, please reopen or comment on it. If you don't have permissions to reopen this ticket, or you want to discuss an issue, please reach out via the developer mailing list.
.