Project

Profile

Help

Issue #1465

closed

All versions in pulp get associated during sync, even if not in remote feed

Added by mhrivnak almost 9 years ago. Updated over 5 years ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Assignee:
Sprint/Milestone:
-
Start date:
Due date:
Estimated time:
Severity:
2. Medium
Version - Python:
1.0.1
Platform Release:
Target Release - Python:
1.1.0
OS:
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
Pulp 2
Sprint:
Quarter:

Description

During sync, there is a check to see if each package has versions already in pulp, but not associated with the repo. The importer incorrectly associates ALL versions that are in pulp, instead of only the ones in the upstream feed.

To reproduce:

  1. sync a package by name from pypi to repo "foo"
  2. create a new package with the same name but a unique and scary version (perhaps 0.0.93.soclose), and upload it to repo "bar"
  3. sync repo "foo" again
  4. note that your scary new uploaded version found its way into repo foo!

The offending code is here: https://github.com/pulp/pulp_python/blob/pulp-python-1.0.1-1/plugins/pulp_python/plugins/importers/sync.py#L101

It fails to limit "versions_to_associate" to only versions in "all_versions".

I noticed this because of package "numpy" at version "1.10.0.post2". This bug is masking a different bug, where that package sometimes is detected as version "1.10.0.post2", and sometimes as just "1.10.0", and as a result would fail to be associated during sync when already present in pulp, but not in the current repo.


Related issues

Related to Python Support - Issue #1466: package version discrepancy in pypi API causes problems for syncCLOSED - CURRENTRELEASEActions
Actions #1

Updated by mhrivnak almost 9 years ago

  • Related to Issue #1466: package version discrepancy in pypi API causes problems for sync added
Actions #2

Updated by mhrivnak almost 9 years ago

  • Status changed from ASSIGNED to POST

Added by mhrivnak almost 9 years ago

Revision 05c2dd33 | View on GitHub

converted to use mongoengine

fixes #877 fixes #1465

https://pulp.plan.io/issues/877 https://pulp.plan.io/issues/1465

1465 was fixed by accident in the course of doing the conversion

Actions #4

Updated by mhrivnak almost 9 years ago

  • Status changed from POST to MODIFIED
  • % Done changed from 0 to 100
Actions #5

Updated by mhrivnak almost 9 years ago

  • Target Release - Python set to 1.1.0
Actions #6

Updated by rbarlow almost 9 years ago

  • Status changed from MODIFIED to 5
Actions #7

Updated by semyers over 8 years ago

  • Status changed from 5 to CLOSED - CURRENTRELEASE
Actions #8

Updated by bmbouter over 5 years ago

  • Tags Pulp 2 added

Also available in: Atom PDF