Project

Profile

Help

Issue #1054

closed

pulp repoauth checking should be OR'd across plugins, not ANDed

Added by cduryee almost 9 years ago. Updated about 5 years ago.

Status:
CLOSED - WONTFIX
Priority:
Normal
Assignee:
-
Category:
-
Sprint/Milestone:
-
Start date:
Due date:
Estimated time:
Severity:
2. Medium
Version:
Platform Release:
OS:
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
Pulp 2
Sprint:
Quarter:

Description

The pulp repoauth plugin loop currently has the following code:

    # loop through authenticators. If any return False, kick the user out.
    for auth_method in authenticators:
        if not authenticators[auth_method](environ):
            return False

This should instead loop through each authenticator, and if one returns True, let the user in. This is more in-line with what developers expect to occur, and avoids issues with one auth plugin blocking another.

Note that another issue will be put in to allow enabling/disabling individual auth plugins based on a single config file. Currently you can only disable authentication entirely but not at a granular level.

Actions #1

Updated by cduryee almost 9 years ago

  • Status changed from ASSIGNED to NEW
  • Assignee deleted (cduryee)
  • Platform Release set to 3.0.0

I spent about a day on this and was unable to make this change in a way that was compatible with a Y stream release. The issue is that some plugins assume they are being ANDed, so they would require a rewrite in order to work with this change. Moving back to NEW, and setting release to 3.0.

Actions #2

Updated by bmbouter almost 9 years ago

  • Status changed from NEW to ASSIGNED
  • Assignee set to cduryee
  • Platform Release deleted (3.0.0)
  • Triaged changed from No to Yes

Removed the target release. We're not sure if a release has been cut that includes the AND behavior, but either way it needs to be implemented.

Actions #3

Updated by rbarlow about 8 years ago

  • Status changed from ASSIGNED to NEW
  • Assignee deleted (cduryee)
Actions #4

Updated by bmbouter about 5 years ago

  • Status changed from NEW to CLOSED - WONTFIX
Actions #5

Updated by bmbouter about 5 years ago

Pulp 2 is approaching maintenance mode, and this Pulp 2 ticket is not being actively worked on. As such, it is being closed as WONTFIX. Pulp 2 is still accepting contributions though, so if you want to contribute a fix for this ticket, please reopen or comment on it. If you don't have permissions to reopen this ticket, or you want to discuss an issue, please reach out via the developer mailing list.

Actions #6

Updated by bmbouter about 5 years ago

  • Tags Pulp 2 added

Also available in: Atom PDF