Project

Profile

Help

Story #8265

Updated by pulpbot almost 3 years ago

 

 **Ticket moved to GitHub**: "pulp/pulpcore/1972":https://github.com/pulp/pulpcore/issues/1972 




 ---- 


 Right now we have checks in two different places in our application: 
 * [storage checks in pulpcore.app.checks](https://github.com/pulp/pulpcore/blob/7a75b7c0af7c6800ea6eedbf0d7b02617958f3ac/pulpcore/app/checks.py) 
 * [settings checks in the settings file](https://github.com/pulp/pulpcore/blob/7a75b7c0af7c6800ea6eedbf0d7b02617958f3ac/pulpcore/app/settings.py#L274-L345) 

 The first set of checks aren't being run [except by Katello](https://github.com/theforeman/puppet-pulpcore/pull/155). This is because ["checks are not run as part of the WSGI stack that is used in deployment"](https://docs.djangoproject.com/en/3.1/topics/checks/). 

 We should standardize on one approach to checks that will be run: 
 * When the `pulpcore-manager check` command is run 
 * When pulpcore is run as part of a WSGI stack 

Back