Issue #4518
Updated by bherring over 5 years ago
h2. Concern The behavior in 2.18.1 is incorrect for modular errata copy which could affect Satellite. The correct behavior is now seen, recently, in 2-master. Verified incorrect behavior with Tanya. h2. Chronology A regression in test_modular_copy.py [0] was noted in nightly [1] once libsolv [2] was resolved by pcreech (thanks!) on 3/3/2019 in #4405. Upon looking through the newly delivered modular documentation [3], it appears that that current behavior in 2-master is correct and the behavior test_modular_copy.py and resulting behavior in 2.18.1-stable is incorrect (and has been since Sept 2018 [0]). The test was originally written and approved without the understanding of the *modulemd* copies needed as part of the errata. Please note the CLI examples below for comparisons between 2.18.1 and latest 2-master for all permutations of *--recursive* and *--recursive-conservative* through the CLI. h3. Test Update The test with the correct modular errata copy behavior check [4] is already submitted and awaiting development designation of problem scope before implementing into test repositories. Until then, we have a known, failing test in nightly. h2. 2.18.1 Behaviors (since Sept 21 2018 - 2.18.1-GA) [incorrect] h3. --recursive <pre> [root@rhel76-218 ~]# pulp-admin rpm repo copy errata --str-eq="errata_id=RHEA-2012:0059" --from-repo-id=test --to-repo-id=new --recursive This command may be exited via ctrl+c without affecting the request. [\] Running... Copied: erratum: RHEA-2012:0059 rpm: duck-0.7-1-noarch kangaroo-0.3-1-noarch </pre> h3. --recursive-conservative <pre> [root@rhel76-218 ~]# pulp-admin rpm repo copy errata --str-eq="errata_id=RHEA-2012:0059" --from-repo-id=test --to-repo-id=new --recursive-conservative This command may be exited via ctrl+c without affecting the request. [\] Running... Copied: erratum: RHEA-2012:0059 rpm: duck-0.7-1-noarch kangaroo-0.3-1-noarch </pre> h3. Both <pre> [root@rhel76-218 ~]# pulp-admin rpm repo copy errata --str-eq="errata_id=RHEA-2012:0059" --from-repo-id=test --to-repo-id=new --recursive-conservative --recursive This command may be exited via ctrl+c without affecting the request. [\] Running... Copied: erratum: RHEA-2012:0059 rpm: duck-0.7-1-noarch kangaroo-0.3-1-noarch </pre> h2. 2.19 Behaviors (testable since libsolv issues were resolved on ~3/1) [correct] h3. --recursive <pre> [root@rhel76-219 ~]# pulp-admin rpm repo copy errata --str-eq="errata_id=RHEA-2012:0059" --from-repo-id=test --to-repo-id=new --recursive This command may be exited via ctrl+c without affecting the request. [\] Running... Copied: erratum: RHEA-2012:0059 modulemd: duck-0-20180730233102-deadbeef-noarch kangaroo-0-20180730223407-deadbeef-noarch rpm: duck-0.7-1-noarch kangaroo-0.3-1-noarch </pre> h3. --recursive-conservative <pre> [root@rhel76-219 ~]# pulp-admin rpm repo copy errata --str-eq="errata_id=RHEA-2012:0059" --from-repo-id=test --to-repo-id=new --recursive-conservative This command may be exited via ctrl+c without affecting the request. [\] Running... Copied: erratum: RHEA-2012:0059 modulemd: duck-0-20180730233102-deadbeef-noarch kangaroo-0-20180730223407-deadbeef-noarch rpm: duck-0.7-1-noarch kangaroo-0.3-1-noarch </pre> h3. Both <pre> [root@rhel76-219 ~]# pulp-admin rpm repo copy errata --str-eq="errata_id=RHEA-2012:0059" --from-repo-id=test --to-repo-id=new --recursive-conservative --recursive This command may be exited via ctrl+c without affecting the request. [\] Running... Copied: erratum: RHEA-2012:0059 modulemd: duck-0-20180730233102-deadbeef-noarch kangaroo-0-20180730223407-deadbeef-noarch rpm: duck-0.7-1-noarch kangaroo-0.3-1-noarch </pre> h2. References [0] - https://github.com/PulpQE/Pulp-2-Tests/commit/98a096f3d8defd23e3b7608249b87629b647794e#diff-7b8230102daf801887b80fe1b295e564 [1] - https://pulp-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/view/Pulp%202%20-%20Master/job/pulp-2-master-dev-rhel7/372/testReport/ [2] - https://pulp.plan.io/issues/4405 [3] - https://github.com/pulp/pulp_rpm/blob/656d34eb2c4986574ffa8a95c1c61e9a1233b6cf/docs/user-guide/features.rst [4] - https://github.com/PulpQE/Pulp-2-Tests/pull/168