Project

Profile

Help

Actions
Send by e-mail Copy link

Task #5641

closed

Update PR checklist to cover actual needs

Added by ppicka over 3 years ago. Updated about 1 year ago.

Status:
CLOSED - DUPLICATE
Priority:
Normal
Assignee:
-
Category:
-
Sprint/Milestone:
-
Start date:
Due date:
% Done:

0%

Estimated time:
Platform Release:
Groomed:
No
Sprint Candidate:
No
Tags:
Documentation
Sprint:
Quarter:

Description

Ticket moved to GitHub: "pulp/pulpcore/1852":https://github.com/pulp/pulpcore/issues/1852

There is a checklist in our docs [0] but doesn't cover towncrier and possibility to update auto-generated API docs.

[0] https://docs.pulpproject.org/en/3.0/nightly/contributing/pull-request-walkthrough.html#checklist

Actions
Copy link
 #1

Updated by daviddavis over 3 years ago

The checklist does cover towncrier. It's number 4. We should call out docstring in the checklist though.

Also, in the conversation that motivated this issue, there was mention of https://devchecklists.com/. They have a PR checklist:

https://devchecklists.com/pull-requests-checklist/

Along with some others. We could maybe check to see if we're missing anything.

Actions
Copy link
 #2

Updated by pulpbot about 1 year ago

  • Description updated (diff)
  • Status changed from NEW to CLOSED - DUPLICATE
Actions
Send by e-mail Copy link

Also available in: Atom PDF