Project

Profile

Help

Refactor #132 ยป Refactor #285 - 2015-01-23T15_47_24Z.eml

rbarlow, 01/23/2015 04:47 PM

 
Date: Fri, 23 Jan 2015 16:47:24 +0100
From: rbarlow@redhat.com
To: dropbox+pulp+c71e@plan.io
Message-ID: <54c26d0c886a3_fda3fb273e87e9c60748@apollo.mail>
in-reply-to: redmine.issue-132.20150122204852@plan.io
Subject: Re: [Pulp - Refactor #132] (NEW) Ensure all tests can be run
independantly
Mime-Version: 1.0
Content-Type: multipart/mixed;
boundary=ENUSkXN5VTNMgxI292JI7G144jmvURfMr;
charset=UTF-8
Content-Transfer-Encoding: 7bit
X-Scanned-By: MIMEDefang 2.68 on 10.5.11.26
X-HE-Spam-Level: -----
X-HE-Spam-Score: -5.0
X-HE-Spam-Report: Content analysis details: (-5.0 points) pts rule name
description ---- ----------------------
-------------------------------------------------- -5.0 RCVD_IN_DNSWL_HI RBL:
Sender listed at http://www.dnswl.org/, high trust [209.132.183.28 listed in
list.dnswl.org]
X-HE-SPF: PASSED


--ENUSkXN5VTNMgxI292JI7G144jmvURfMr
Content-Type: text/plain;
charset=utf-8
Content-Transfer-Encoding: quoted-printable

On 01/22/2015 03:48 PM, Brian Bouterse wrote:
> This can be solved by having run_tests() connect
> to the database once and for all and removing calls to initialize()
> throughout the test code.

I don't believe this will work, because run_tests() is a separate
process from nosetests (it uses subprocess to call nose.)

> --- Please write your response above this line ---
> =

> Issue #132 has been reported by Brian Bouterse.
> -----------------------------------------------------------------------=
-
> =

> =

> Refactor #132: Ensure all tests can be run independantly
> <https://pulp.plan.io/issues/132>
> =

> * Author: Brian Bouterse
> * Status: NEW
> * Priority: Normal
> * Assignee:
> * Category:
> * Sprint/Milestone:
> * Target Release: =

> =

> *The Problem*
> Many tests rely on the state leftover from other tests. This causes som=
e
> tests to pass when run with ./run-tests.py but fail when run
> individually. All tests should be able to run individually in both
> platform and all plugins.
> =

> This story is expected to be done after #131
> <https://pulp.plan.io/issues/131>
> =

> *Which tests need fixing?*
> Install nosepipe <https://pypi.python.org/pypi/nosepipe/> and modify
> pulp.devel.test_runner.run_tests to include the --with-process-isolatio=
n
> option. Run the tests on platform or your plugins using ./run-tests.py.=

> They will take a long time. Look at the output for the failed tests;
> those are the ones that are not independent.
> =

> *Expected problems*
> =

> * There will likely be many non-initialized database errors from test=

> code attempting to use the database but relying on a previous test
> to configuring it. This can be solved by having run_tests() connect=

> to the database once and for all and removing calls to initialize()=

> throughout the test code. A consistent base class used by all unit
> tests is also an option.
> =

> -----------------------------------------------------------------------=
-
> =

> You have received this notification because you have either subscribed
> to or are involved in a project on pulp Planio.
> To change your notification preferences, please click here:
> https://pulp.plan.io/my/account
> =

> =

> =

> This notification was cheerfully delivered by <https://plan.io/>
> =

> Planio <https://plan.io/>
> =



--ENUSkXN5VTNMgxI292JI7G144jmvURfMr--
    (1-1/1)