Issue #7354: RPM Mirrorlist comments cause an exception - RPM Support - Pulp

Maintenance: Planio will be observing a scheduled maintenance window this Sunday, November 10, 2024 from 20:00 UTC until 21:00 UTC to perform important network maintenance in our primary data center. Your Planio account will be unavailable for a few minutes during this maintenance window.

Actions

Send by e-mail Copy link

Issue #7354

closed

RPM Mirrorlist comments cause an exception

Added by cognifloyd about 4 years ago. Updated about 4 years ago.

Status:

CLOSED - CURRENTRELEASE

Priority:

Normal

Assignee:

cognifloyd

Sprint/Milestone:

3.6.2

Start date:

Due date:

Estimated time:

Severity:

2. Medium

Version:

Platform Release:

OS:

Triaged:

Yes

Groomed:

Sprint Candidate:

Tags:

Sprint:

Quarter:

Description

The fedora mirrorlists have a comment at the top. For example:

https://mirrors.fedoraproject.org/mirrorlist?repo=epel-8&arch=x86_64&country=US

# repo = epel-8 arch = x86_64 country = US

The fetch_mirror function's docstring says it skips non-matching lines, but the task dies trying to access .group(2) on None.

        "error": {
            "description": "'NoneType' object has no attribute 'group'",
            "traceback": "  File \"/usr/local/lib/pulp/lib64/python3.6/site-packages/rq/worker.py\", line 934, in perform_job\n    rv = job.perform()\n  File \"/usr/local/lib/pulp/lib64/python3.6/site-packages/rq/job.py\", line 686, in perform\n    self._result = self._execute()\n  File \"/usr/local/lib/pulp/lib64/python3.6/site-packages/rq/job.py\", line 692, in _execute\n    return self.func(*self.args, **self.kwargs)\n  File \"/usr/local/lib/pulp/lib64/python3.6/site-packages/pulp_rpm/app/tasks/synchronizing.py\", line 211, in synchronize\n    remote_url = fetch_remote_url(remote)\n  File \"/usr/local/lib/pulp/lib64/python3.6/site-packages/pulp_rpm/app/tasks/synchronizing.py\", line 138, in fetch_remote_url\n    return fetch_mirror(remote)\n  File \"/usr/local/lib/pulp/lib64/python3.6/site-packages/pulp_rpm/app/tasks/synchronizing.py\", line 124, in fetch_mirror\n    repodata_exists = get_repomd_file(remote, match.group(2))\n"
        },