Project

Profile

Help

Story #5398

Updated by pulpbot over 2 years ago

 

 **Ticket moved to GitHub**: "pulp/pulp_ansible/689":https://github.com/pulp/pulp_ansible/issues/689 




 ---- 


 ### Background 

 The Collection model current has a many-to-many relationship with Tags [here](https://github.com/pulp/pulp_ansible/blob/master/pulp_ansible/app/models.py#L140) 

 ### Desire 

 As a user, I can provide tags as a get style parameter similar to existing DRF filtering. Multiple tags specified should be treated as an AND so each collection should only be returned if it contains ALL of them. 

 ### Details 

 This should extend the [CollectionVersionFilter here](https://github.com/pulp/pulp_ansible/blob/1bbea075d929e42320f2a7f7e408229dadd5b3a4/pulp_ansible/app/viewsets.py#L80-L83) 

 Also this request was originally implemented by Galaxy [here](https://github.com/ansible/galaxy/blob/devel/galaxy/api/internal/search.py#L105-L109) as two queries where the first one returns pks of collections, and then further fitlers the queryset. Note this implementation is an OR while we need an AND. 

 Galaxy later opened a PR to update their implementation to an AND [see here](https://github.com/ansible/galaxy/pull/1898/files#diff-59edf52f1534e96b58a1b4db42ea4279R258) 

 

Back