Project

Profile

Help

Task #3379

Updated by bmbouter about 6 years ago

Make the following checks required: 
 * PR review 
 * docs builders check 
 * Travis CI passing 
 * "default" which is the Jenkins test runner check 

 For the following repos and branches: 
 * 'pulp' repo 'master' branch 
 * 'pulp' repo '3.0-dev' branch 
 * 'pulp_file' repo 'master' branch 

 In terms of a disable/reenable process: 

 From the github docs it looks like an 'Administrator' of a repository can enable/disable the required checks. Currently the following people have that permissions: @ipanova, @rchan, @jortel, @ttereshc, and @bmbouter 

 To temporarily disable: 

 1. Contact one of ^ admins via pulp-dev and irc that a check is failing permanently 
 2. Discuss what the issue is and make a decision to disable the checks or not. 
 3. If disabling, disable via github and make and issue to re-enable 
 4. notify pulp-dev with an update of the changes and the issue link 
 5. work to re-enable checks as soon as possible 

 We should put ^ and an overall update of the latest required checks into the pulp2 and pulp3 docs. We can put those into these locations: 

 pulp2:    https://docs.pulpproject.org/dev-guide/contributing/merging.html#pull-requests 
 pulp3:    https://docs.pulpproject.org/dev-guide/contributing/merging.html#pull-requests 

Back