https://pulp.plan.io/https://pulp.plan.io/favicon.ico2021-09-29T08:55:25ZPulpRPM Support - Issue #9464: Regression: Syncing username+password authenticated remotes failshttps://pulp.plan.io/issues/9464?journal_id=760732021-09-29T08:55:25Zmartin
<ul><li><strong>Copied from</strong> <i><a class="issue tracker-1 status-11 priority-7 priority-high2 closed" href="/issues/9329">Issue #9329</a>: Regression: Syncing mirrolist based remotes do fail again since 3.14.1</i> added</li></ul> RPM Support - Issue #9464: Regression: Syncing username+password authenticated remotes failshttps://pulp.plan.io/issues/9464?journal_id=760902021-09-29T12:17:50Zdaviddavis
<ul></ul><p>Looks like this change broke this functionality:</p>
<p><a href="https://github.com/pulp/pulp_rpm/commit/db55c27a9e78a18b64849915bc33628c8a9456fd" class="external">https://github.com/pulp/pulp_rpm/commit/db55c27a9e78a18b64849915bc33628c8a9456fd</a></p> RPM Support - Issue #9464: Regression: Syncing username+password authenticated remotes failshttps://pulp.plan.io/issues/9464?journal_id=760922021-09-29T12:18:11Zdaviddavis
<ul><li><strong>Related to</strong> <i><a class="issue tracker-3 status-11 priority-6 priority-default closed parent" href="/issues/9457">Story #9457</a>: [EPIC] As a user, I am given an error if I try to use a url with basic auth</i> added</li></ul> RPM Support - Issue #9464: Regression: Syncing username+password authenticated remotes failshttps://pulp.plan.io/issues/9464?journal_id=760972021-09-29T13:29:35Zggainey
<ul></ul><p>There are a couple of approaches available.</p>
<p>One is to sanitize a remote-url <strong>at remote-creation-time</strong>. That implies using urlparse() to break up the URL, "do the right thing" with the pieces (ie, strip user/pwd out and put them in the right fields on the remote, urlencode things that need to be url-encoded, etc), and reassemble the URL to be correct. A second is to do this at download-time, and fix the url "on the fly"</p>
<p>The first is better, but will require a migration to inspect every stored-remote-url and fix them up. The second is ad-hoc, but doesn't require any fixing up of existing data.</p>
<p>More thought required :)</p> RPM Support - Issue #9464: Regression: Syncing username+password authenticated remotes failshttps://pulp.plan.io/issues/9464?journal_id=761002021-09-29T13:32:14Zggainey
<ul></ul><p>One serious issue with letting username/pwd stay on the URL, is that it means they're not protected by the db-encryption we've added for sensitive fields. That leads us even more to option-1 above.</p> RPM Support - Issue #9464: Regression: Syncing username+password authenticated remotes failshttps://pulp.plan.io/issues/9464?journal_id=761032021-09-29T14:58:15Zggainey
<ul><li><strong>Status</strong> changed from <i>NEW</i> to <i>ASSIGNED</i></li><li><strong>Assignee</strong> changed from <i>dalley</i> to <i>ggainey</i></li></ul> RPM Support - Issue #9464: Regression: Syncing username+password authenticated remotes failshttps://pulp.plan.io/issues/9464?journal_id=761072021-09-29T16:06:12Zipanova@redhat.comipanova@redhat.com
<ul></ul><p>ggainey wrote:</p>
<blockquote>
<p>There are a couple of approaches available.</p>
<p>One is to sanitize a remote-url <strong>at remote-creation-time</strong>. That implies using urlparse() to break up the URL, "do the right thing" with the pieces (ie, strip user/pwd out and put them in the right fields on the remote, urlencode things that need to be url-encoded, etc), and reassemble the URL to be correct. A second is to do this at download-time, and fix the url "on the fly"</p>
</blockquote>
<p>Should not we just raise a validation error during remote creation instead of this obscure autopsy? :)</p>
<blockquote>
<p>The first is better, but will require a migration to inspect every stored-remote-url and fix them up. The second is ad-hoc, but doesn't require any fixing up of existing data.</p>
<p>More thought required :)</p>
</blockquote> RPM Support - Issue #9464: Regression: Syncing username+password authenticated remotes failshttps://pulp.plan.io/issues/9464?journal_id=761112021-09-29T17:58:49Zggainey
<ul><li><strong>Sprint</strong> changed from <i>Sprint 105</i> to <i>Sprint 106</i></li></ul> RPM Support - Issue #9464: Regression: Syncing username+password authenticated remotes failshttps://pulp.plan.io/issues/9464?journal_id=761122021-09-29T17:59:24Zggainey
<ul><li><strong>Copied to</strong> <i><a class="issue tracker-7 status-11 priority-7 priority-high2 closed" href="/issues/9472">Backport #9472</a>: Backport to 3.14.z: Regression: Syncing username+password authenticated remotes fails</i> added</li></ul> RPM Support - Issue #9464: Regression: Syncing username+password authenticated remotes failshttps://pulp.plan.io/issues/9464?journal_id=761222021-09-29T18:46:25Zpulpbot
<ul><li><strong>Status</strong> changed from <i>ASSIGNED</i> to <i>POST</i></li></ul><p>PR: <a href="https://github.com/pulp/pulp_rpm/pull/2138" class="external">https://github.com/pulp/pulp_rpm/pull/2138</a></p> RPM Support - Issue #9464: Regression: Syncing username+password authenticated remotes failshttps://pulp.plan.io/issues/9464?journal_id=761232021-09-29T19:04:49Zggainey
<ul><li><strong>Status</strong> changed from <i>POST</i> to <i>MODIFIED</i></li></ul><p>Applied in changeset <a class="changeset" title="Restore embedded-basic-auth-in-url functionality. fixes #9464 [nocoverage]" href="https://pulp.plan.io/projects/pulp_rpm/repository/9/revisions/6cbae29b4a08e5452f3634c204a4266f344f8b6c">6cbae29b4a08e5452f3634c204a4266f344f8b6c</a>.</p> RPM Support - Issue #9464: Regression: Syncing username+password authenticated remotes failshttps://pulp.plan.io/issues/9464?journal_id=766822021-10-20T19:07:51Zpulpbot
<ul><li><strong>Status</strong> changed from <i>MODIFIED</i> to <i>CLOSED - CURRENTRELEASE</i></li></ul>