Project

Profile

Help

Issue #8906

closed

decide where pulpcore-worker should be installed

Added by evgeni almost 3 years ago. Updated almost 3 years ago.

Status:
CLOSED - WONTFIX
Priority:
Normal
Assignee:
-
Category:
-
Sprint/Milestone:
-
Start date:
Due date:
Estimated time:
Severity:
2. Medium
Version:
Platform Release:
OS:
Triaged:
No
Groomed:
No
Sprint Candidate:
No
Tags:
Sprint:
Quarter:

Description

Ohai,

with pulpcore 3.13, there is a new pulpcore-worker script (https://github.com/pulp/pulpcore/commit/6af4885832b2fb473d8e455a2a3602a8e63765b7, #8721) which should be used as the main entry point for all things worker.

The Python packaging uses entry_points.console_scripts, which places that script in /usr/bin when we build an RPM from that Python package.

However the installer expects it to be in __pulp_daemons_dir (https://github.com/pulp/pulp_installer/commit/39a886965dca3cc30778329d7b1ccfbd32bb7b18) which defaults to /usr/libexec/pulpcore for RPM based installs.

I am fine with either location, but right now Python and Installer contradict each other.

(FWIW, this is "fine" for pip based installs, as there __pulp_daemons_dir points at bin)

Actions #1

Updated by evgeni almost 3 years ago

Pro /usr/libexec/pulpcore:

  • selinux already labels this folder correctly, /usr/bin would require changes to the policy
Actions #2

Updated by mdellweg almost 3 years ago

It looks like there is no (good) way to specify that a console_script should be placed somewhere else.

So the conclusion seems to be that in RPM Packaging, either the file should be moved to libexec or a wrapper should be installed there to be able to set the selabels properly.

Actions #3

Updated by evgeni almost 3 years ago

Thanks.

I consider this decided then and will add a wrapper in packaging.

Actions #4

Updated by dkliban@redhat.com almost 3 years ago

  • Status changed from NEW to CLOSED - WONTFIX

Looks like we came to a decision. Closing.

Also available in: Atom PDF