Project

Profile

Help

Issue #8006

closed

pulp should treat empty string in username and password as null value

Added by ipanova@redhat.com over 3 years ago. Updated over 3 years ago.

Status:
CLOSED - WONTFIX
Priority:
Normal
Assignee:
-
Sprint/Milestone:
-
Start date:
Due date:
Estimated time:
Severity:
2. Medium
Version:
Platform Release:
OS:
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
Pulp 2
Sprint:
Quarter:

Description

when setting a proxy pulp should treat empty string in username and password as null value

Actions #1

Updated by ggainey over 3 years ago

Thoughts off the top of my head:

First - if you don't have a username or password - don't set them, or set them to 'nil'. Setting them to empty-string is choosing to set them to something, expecting Pulp2 to "know better" feels like a recipe for edge cases.

Second - "treat empty string as null", especially for passwords, makes Pulp2 make assumptions about the behavior of the login-system on the proxy. If that system sees null-pwd and empty-string-pwd as two different choices, then we have just created another problem, that doesn't have a workaround.

My first take on this request is to close NOTABUG. Def needs input from more ppl tho.

Actions #2

Updated by ipanova@redhat.com over 3 years ago

  • Tags Pulp 2 added
Actions #3

Updated by dalley over 3 years ago

  • Triaged changed from No to Yes
Actions #4

Updated by ipanova@redhat.com over 3 years ago

  • Platform Release set to 2.21.5
Actions #5

Updated by ipanova@redhat.com over 3 years ago

  • Status changed from NEW to CLOSED - WONTFIX

Turned out that this trivial fix would require to touch code for multiple plugins, given the risk of introducing regressions in multiple plugins i would rather let the current code as is and treat empty password only if a null value was provided.

Actions #6

Updated by ipanova@redhat.com over 3 years ago

  • Platform Release deleted (2.21.5)

Also available in: Atom PDF