Project

Profile

Help

Issue #7933

When files are moved/removed in the plugin_template, they are not updated in plugins

Added by daviddavis about 1 year ago. Updated 12 months ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Assignee:
-
Category:
-
Sprint/Milestone:
-
Start date:
Due date:
Estimated time:
Severity:
2. Medium
Version:
Platform Release:
OS:
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
Plugin Template
Sprint:
Sprint 87
Quarter:

Description

Steps to reproduce:

mv templates/github/.ci/scripts/release_requirements.txt.j2 templates/github/.ci/assets/
./plugin-template --github pulp_file

pulp_file will end up with a new .ci/assets/release_requirements.txt file but the old .ci/scripts/release_requirements.txt remains.

This could lead to lots of outdated and unused files in plugins.

Associated revisions

Revision 00480ae8 View on GitHub
Added by daviddavis about 1 year ago

Added a deprecation check for moved or removed files

fixes #7933

History

#1 Updated by daviddavis about 1 year ago

This is a bit challenging to solve. A couple options I thought of:

  1. Keep a list of deprecated files. Whenever a file is moved/removed, we need to add it to this deprecated list. When the plugin_template finds one of these files, it either:
    • issues a warning or
    • it automatically deletes the file.
  2. Add a changelog entry whenever we move or remove files.

#2 Updated by daviddavis about 1 year ago

  • Subject changed from When files are moved in the plugin_template, they are not moved in plugins to When files are moved/removed in the plugin_template, they are not updated in plugins

#3 Updated by pulpbot about 1 year ago

  • Status changed from NEW to POST

#4 Updated by fao89 about 1 year ago

  • Triaged changed from No to Yes
  • Sprint set to Sprint 87

#5 Updated by daviddavis about 1 year ago

  • Status changed from POST to MODIFIED

#6 Updated by ttereshc 12 months ago

  • Status changed from MODIFIED to CLOSED - CURRENTRELEASE

Also available in: Atom PDF