Project

Profile

Help

Issue #7826

closed

Sync breaks when it is not possible to determine the highest collection version

Added by fao89 over 3 years ago. Updated over 3 years ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Assignee:
Sprint/Milestone:
Start date:
Due date:
Estimated time:
Severity:
2. Medium
Platform Release:
OS:
Triaged:
No
Groomed:
No
Sprint Candidate:
No
Tags:
Sprint:
Quarter:

Description

if semver.compare(collection_version.version, last_highest.version) > 0:

https://github.com/pulp/pulp_ansible/blob/master/pulp_ansible/app/tasks/collections.py#L223

In [1]: import semantic_version as semver

In [2]: semver.compare("9.1.0-dev.1+40688.git966d0b3", "9.1.0-dev.1+40390.gita455009")
Out[2]: NotImplemented

In [3]: semver.Version("9.1.0-dev.1+40688.git966d0b3") > semver.Version("9.1.0-dev.1+40390.gita455009")
Out[3]: False

In [4]: semver.Version("9.1.0-dev.1+40688.git966d0b3") < semver.Version("9.1.0-dev.1+40390.gita455009")
Out[4]: False

In [5]: semver.Version("9.1.0-dev.1+40688.git966d0b3") == semver.Version("9.1.0-dev.1+40390.gita455009")
Out[5]: False

https://galaxy.ansible.com/api/v2/collections/brightcomputing/bcm/versions/

Actions #1

Updated by fao89 over 3 years ago

  • Description updated (diff)
Actions #2

Updated by fao89 over 3 years ago

  • Sprint/Milestone set to 0.5.2
Actions #3

Updated by fao89 over 3 years ago

  • Status changed from NEW to ASSIGNED
  • Assignee set to fao89
Actions #4

Updated by pulpbot over 3 years ago

  • Status changed from ASSIGNED to POST

Added by Fabricio Aguiar over 3 years ago

Revision 0da49086 | View on GitHub

Fix semver comparison

https://pulp.plan.io/issues/7826 closes #7826

Actions #5

Updated by Anonymous over 3 years ago

  • Status changed from POST to MODIFIED

Added by Fabricio Aguiar over 3 years ago

Revision 0e34912f | View on GitHub

Fix semver comparison

https://pulp.plan.io/issues/7826 closes #7826

Actions #7

Updated by pulpbot over 3 years ago

  • Status changed from MODIFIED to CLOSED - CURRENTRELEASE

Also available in: Atom PDF