Project

Profile

Help

Actions
Send by e-mail Copy link

Issue #7767

closed

pulp_ansible doesn't handle trailing slashes in URLs correctly

Added by daviddavis about 3 years ago. Updated about 3 years ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Assignee:
daviddavis
Sprint/Milestone:
0.5.0
Start date:
Due date:
Estimated time:
Severity:
2. Medium
Platform Release:
OS:
Triaged:
No
Groomed:
No
Sprint Candidate:
No
Tags:
Sprint:
Quarter:

Description

From the Ansible Galaxy User Guide[0]: "The url option for each server name must end with a forward slash /."

Note though, however, that the ansible-galaxy CLI does a special substitution for galaxy:

https://github.com/ansible/ansible/blob/a51a6f4a259b45593c3f803737c6d5d847258a83/lib/ansible/galaxy/api.py#L52-L53

I think we should just copy what the ansible-galaxy CLI is doing.

[0] https://github.com/ansible/ansible/blob/a51a6f4a259b45593c3f803737c6d5d847258a83/docs/docsite/rst/shared_snippets/galaxy_server_list.txt#L19

Actions
Copy link
 #1

Updated by daviddavis about 3 years ago

  • Project changed from Pulp to Ansible Plugin
Actions
Copy link
 #2

Updated by daviddavis about 3 years ago

  • Description updated (diff)
Actions
Copy link
 #3

Updated by daviddavis about 3 years ago

  • Status changed from NEW to ASSIGNED
  • Assignee set to daviddavis
Actions
Copy link
 #4

Updated by pulpbot about 3 years ago

  • Status changed from ASSIGNED to POST

Added by daviddavis about 3 years ago

Revision 3fda9ae5 | View on GitHub

Added validation and fixed handling of trailing slashes in URLs

fixes #7767

Actions
Copy link
 #5

Updated by daviddavis about 3 years ago

  • Status changed from POST to MODIFIED
Actions
Copy link
 #6

Updated by fao89 about 3 years ago

  • Sprint/Milestone set to 0.5.0
Actions
Copy link
 #7

Updated by pulpbot about 3 years ago

  • Status changed from MODIFIED to CLOSED - CURRENTRELEASE
Actions
Send by e-mail Copy link

Also available in: Atom PDF