Project

Profile

Help

Send by e-mail

Issue #7767

pulp_ansible doesn't handle trailing slashes in URLs correctly

Added by daviddavis 8 months ago. Updated 8 months ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Assignee:
daviddavis
Sprint/Milestone:
0.5.0
Start date:
Due date:
Estimated time:
Severity:
2. Medium
Platform Release:
OS:
Triaged:
No
Groomed:
No
Sprint Candidate:
No
Tags:
Sprint:
Quarter:

Description

From the Ansible Galaxy User Guide[0]: "The url option for each server name must end with a forward slash /."

Note though, however, that the ansible-galaxy CLI does a special substitution for galaxy:

https://github.com/ansible/ansible/blob/a51a6f4a259b45593c3f803737c6d5d847258a83/lib/ansible/galaxy/api.py#L52-L53

I think we should just copy what the ansible-galaxy CLI is doing.

[0] https://github.com/ansible/ansible/blob/a51a6f4a259b45593c3f803737c6d5d847258a83/docs/docsite/rst/shared_snippets/galaxy_server_list.txt#L19

Associated revisions

Revision 3fda9ae5 View on GitHub
Added by daviddavis 8 months ago

Added validation and fixed handling of trailing slashes in URLs

fixes #7767

History

#1 Updated by daviddavis 8 months ago

  • Project changed from Pulp to Ansible Plugin

#2 Updated by daviddavis 8 months ago

  • Description updated (diff)

#3 Updated by daviddavis 8 months ago

  • Status changed from NEW to ASSIGNED
  • Assignee set to daviddavis

#4 Updated by pulpbot 8 months ago

  • Status changed from ASSIGNED to POST

#5 Updated by daviddavis 8 months ago

  • Status changed from POST to MODIFIED

#6 Updated by fao89 8 months ago

  • Sprint/Milestone set to 0.5.0

#7 Updated by pulpbot 8 months ago

  • Status changed from MODIFIED to CLOSED - CURRENTRELEASE

Please register to edit this issue

Send by e-mail

Also available in: Atom PDF